refactor: aztec-cli better volume mounting strategy

[alexghr]

This PR changes aztec-cli.sh's mounting strategy to be more generic, ensuring fewer updates are necessary as new commands are added.

Previous strategy: "for these commands A,B,C,etc, recognize these flags and positional parameters as files/directories. Edge case: for the unbox command, mkdir first then mount"

New strategy: "go through every CLI arg and if it looks like a file or a directory, mount it in the container. Edge case: for the unbox command, mkdir first then mount"

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[alexghr]

Technically add_mount already checks that its argument is an existing directory so this if statement could be skipped.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 98.0 (+2350%)
• note_trial_decrypting_time_in_ms (32): 10.0 (-88%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d02726fd and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,924	867,884	3,449,504
l1_rollup_execution_gas	842,011	3,594,992	22,204,873
l2_block_processing_time_in_ms	1,987 (-2%)	7,652 (+1%)	29,671 (-1%)
note_successful_decrypting_time_in_ms	296 (-1%)	902 (+3%)	3,152 (-2%)
note_trial_decrypting_time_in_ms	⚠️ 98.0 (+2350%)	⚠️ 10.0 (-88%)	133 (-1%)
l2_block_building_time_in_ms	13,131 (-2%)	52,512 (-1%)	209,699
l2_block_rollup_simulation_time_in_ms	11,796 (-2%)	47,195	188,662
l2_block_public_tx_process_time_in_ms	1,290 (-2%)	5,185 (-1%)	20,550 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,617 (-1%)	41,990 (-10%)
note_history_successful_decrypting_time_in_ms	1,990 (-4%)	3,913 (-8%)
note_history_trial_decrypting_time_in_ms	121 (+1%)	144 (-1%)
node_database_size_in_bytes	1,630,520	1,098,676
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	778 (-1%)	61,697	18,905
private-kernel-ordering	123 (-2%)	24,297	8,153
base-rollup	1,767 (-2%)	656,311	814
root-rollup	75.3 (-1%)	4,072	1,097
private-kernel-inner	786 (-2%)	81,568	18,905
public-kernel-private-input	41.4 (-2%)	41,519	18,841
public-kernel-non-first-iteration	26.3 (-2%)	41,497	18,841
merge-rollup	0.949 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547