feat: run solidity tests for all acir artifacts by Maddiaa0 · Pull Request #3161 · AztecProtocol/aztec-packages

Maddiaa0 · 2023-10-31T17:51:20Z

This pr:

Adds secp256k1 circuit and solidity verifier to the tests
Runs a solidity verifier test on ALL acir artifacts
- Generate a proof
- Generate a vk
- Generate sol verification key
- We create anvil on a random port
- Compile the contract using solcjs to orchestrate compilation
- Deploy the contract
- Test the contract with the created prood

This pr builds on #3215 which fixes verifier issues ( in a blanket manner ) not directly addressing the dummy constraints issue that appears to be causing it.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

Maddiaa0 · 2023-10-31T17:52:15Z


    function loadVerificationKey(uint256 vk, uint256 _omegaInverseLoc) internal pure virtual override(BASE) {
-      VK.loadVerificationKey(vk, _omegaInverseLoc);
+        VK.loadVerificationKey(vk, _omegaInverseLoc);


Any changes here are due to new forge fmt rules

AztecBot · 2023-10-31T19:13:30Z

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d707d4e3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,996	867,668	3,449,384
l1_rollup_execution_gas	842,083	3,594,776	22,204,753
l2_block_processing_time_in_ms	1,986	7,510 (-1%)	29,696 (-1%)
note_successful_decrypting_time_in_ms	293 (-1%)	864 (-3%)	3,126 (-3%)
note_trial_decrypting_time_in_ms	95.0 (-5%)	72.0 (-26%)	133 (-1%)
l2_block_building_time_in_ms	13,296	52,344 (-1%)	208,670 (-1%)
l2_block_rollup_simulation_time_in_ms	11,951	47,044 (-1%)	187,634 (-1%)
l2_block_public_tx_process_time_in_ms	1,306	5,163 (-2%)	20,549 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,656 (-1%)	42,516
note_history_successful_decrypting_time_in_ms	2,010 (-1%)	3,931 (-1%)
note_history_trial_decrypting_time_in_ms	121 (+1%)	146 (+2%)
node_database_size_in_bytes	1,632,032	1,099,958
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	773	61,697	18,905
private-kernel-ordering	123	24,297	8,153
base-rollup	1,773	656,311	814
root-rollup	79.4 (+3%)	4,072	1,097
private-kernel-inner	789	81,568	18,905
public-kernel-private-input	41.5 (-1%)	41,519	18,841
public-kernel-non-first-iteration	26.2 (-1%)	41,497	18,841
merge-rollup	0.920 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

v1.7.1

socket-security · 2023-11-03T11:34:13Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
ethers	6.8.1	network, filesystem	`+4`	13.5 MB	ricmoo
solc	0.8.22	filesystem, shell	`+4`	8.81 MB	cameel

LHerskind

Mostly nits related to formatting.

Some of the tests seems to be failing though.

LHerskind · 2023-11-04T07:37:14Z

+const readPublicInputs = (proofAsFields) => {
+  const publicInputs = [];
+  // A proof with no public inputs is 93 fields long
+  const numPublicInputs = proofAsFields.length - 93;


Make a constant for the 93, someday we will have forgotten and try use it for a different scheme or something. Also just easier to follow.

LHerskind · 2023-11-04T07:38:09Z

+const launchAnvil = async (port) => {
+  const handle = spawn("anvil", ["-p", port]);
+
+  // wait until the anvil instance is ready on port 8545


Not on port 8545, but on port instead right?

LHerskind · 2023-11-04T07:38:57Z

+    handle.stderr.on("data", (data) => {
+      const str = data.toString();
+      if (str.includes("error binding")) {
+        reject("we go again baby")


I like. Skibbidy.

LHerskind · 2023-11-04T07:39:50Z

+
+/**
+ * 
+ * @param {number} numPublicInputs 


Seems stale as you compute it from the number of fields

LHerskind · 2023-11-04T07:41:27Z

+ * 
+ * @param {number} numPublicInputs 
+ * @param {Array<String>} proofAsFields 
+ * @returns {Array<Tuple<Array<String>,number>}


Also looks a little different from what I see below.

LHerskind · 2023-11-04T15:34:03Z

+        }
+
+        // This is the message that we would like to confirm
+        std::string message_string = "goblin";


LHerskind · 2023-11-04T15:40:06Z

-            info("Only blake, add2 and recursive circuits are supported at the moment");
-            return 1;
-        }
+        info("Only blake, add2 and recursive circuits are supported at the moment");


We should probably change this to just be "unsupported circuit" so we don't have to keep extending it with specific names.

LHerskind · 2023-11-04T15:42:42Z

-                            addmod(y1y2, y1y2, p),
-                            p
-                        ),
+                        addmod(sub(p, addmod(y2_sqr, y1_sqr, p)), addmod(y1y2, y1y2, p), p),


Is this a forge fmt or how come formatting changed in here? 👀

LHerskind · 2023-11-04T15:46:18Z

+        verifier = IVerifier(address(new EcdsaUltraVerifier()));
+        fuzzer = fuzzer.with_circuit_flavour(DifferentialFuzzer.CircuitFlavour.Ecdsa);
+
+        // Does the noir code do this?


Should this question be an issue or?

Ah, i was thinking this could be a debugging issue will remove

Maddiaa0 · 2023-11-04T16:02:51Z

Mostly nits related to formatting.

Some of the tests seems to be failing though.

I've got some concurrency issues to sort out there

LHerskind

Good job @Maddiaa0 👍

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](#3243)) ([f3d8aae](f3d8aae)), closes [#1285](#1285) * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](#2834)) ([a8f3119](a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](#3268)) ([1a22cae](1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](#3138)) ([d40460e](d40460e)) * Disable circuits tasks ([#3253](#3253)) ([e8945f8](e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](AztecProtocol/aztec-packages#3243)) ([f3d8aae](AztecProtocol/aztec-packages@f3d8aae)), closes [#1285](AztecProtocol/aztec-packages#1285) * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](AztecProtocol/aztec-packages#2834)) ([a8f3119](AztecProtocol/aztec-packages@a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](AztecProtocol/aztec-packages#3268)) ([1a22cae](AztecProtocol/aztec-packages@1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](AztecProtocol/aztec-packages#3138)) ([d40460e](AztecProtocol/aztec-packages@d40460e)) * Disable circuits tasks ([#3253](AztecProtocol/aztec-packages#3253)) ([e8945f8](AztecProtocol/aztec-packages@e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Savio-Sou · 2023-11-22T01:23:12Z

Also resolved #3127?

Maddiaa0 · 2023-11-23T12:22:17Z

Yep; Ill close it out,

Running through bb.js is fine, which leads me to believe it is probably the wrapper that is causing issues now, but ill have to look into it soon. I dont think i have the capacity right now

feat: ecdsa sig verification in aztec packages

36de5b9

Maddiaa0 commented Oct 31, 2023

View reviewed changes

Maddiaa0 marked this pull request as draft October 31, 2023 17:56

Maddiaa0 changed the title ~~feat: ecdsa sig verification in aztec packages~~ feat: ecdsa sig verification solidity test in aztec packages Oct 31, 2023

Maddiaa0 added 4 commits November 2, 2023 12:42

temp

f1de40c

chore: forge init

267cea2

forge install: forge-std

2a452fa

v1.7.1

fix: sol cleanup

de859ee

Maddiaa0 mentioned this pull request Nov 3, 2023

bb: Investigate different proofs being created when proving key is not manually initilaised #3230

Closed

Maddiaa0 added 3 commits November 4, 2023 00:19

fix: more cleanup

b2ab76b

feat: add solidity testing pipeline

66aa9c1

fix: add ci tests

ea049a0

Maddiaa0 force-pushed the md/ecdsa branch from eb7096b to ea049a0 Compare November 4, 2023 00:19

Maddiaa0 added 4 commits November 4, 2023 00:30

fix: add comments to sol tests

a36de68

fix: reenable randomness

0e669ec

fix: remove verifier duplication

6666f35

fix: dependence on solidity test completion

681c6c7

Maddiaa0 changed the title ~~feat: ecdsa sig verification solidity test in aztec packages~~ feat: run solidity tests for all acir artifacts Nov 4, 2023

Maddiaa0 added 3 commits November 4, 2023 01:18

fix: retry if port taken, ensure trap causes failure

299f2be

fix: copy anvil bin

442490a

fix: rework pub inputs thing

e0cc577

Maddiaa0 force-pushed the md/ecdsa branch from 6b94996 to e0cc577 Compare November 4, 2023 02:16

Maddiaa0 added 2 commits November 4, 2023 02:24

docs: bit more docs

6fb8d98

Merge branch 'master' into md/ecdsa

3f82eb3

Maddiaa0 marked this pull request as ready for review November 4, 2023 02:35

Maddiaa0 requested review from LHerskind and charlielye November 4, 2023 02:35

Maddiaa0 enabled auto-merge (squash) November 4, 2023 02:38

LHerskind reviewed Nov 4, 2023

View reviewed changes

Maddiaa0 added 4 commits November 6, 2023 12:43

fix: add init proving key to bb.js, make parallel a flag

f247a12

review fixes

e271243

fix: remove sol tests from circleci

ce051b8

chore: add recursion test to bb test

e9a87d4

Maddiaa0 requested a review from LHerskind November 6, 2023 14:53

fix

c817ed3

LHerskind approved these changes Nov 7, 2023

View reviewed changes

Maddiaa0 merged commit d09f667 into master Nov 7, 2023

Maddiaa0 deleted the md/ecdsa branch November 7, 2023 15:40

AztecBot mentioned this pull request Nov 7, 2023

chore(master): Release 0.14.2 #3266

Merged

Savio-Sou mentioned this pull request Nov 22, 2023

Extend integration-tests to cover ECDSA signature verifications noir-lang/noir#3524

Closed

Maddiaa0 mentioned this pull request Nov 23, 2023

Add recursive proof Solidity tests #3127

Closed

Savio-Sou mentioned this pull request Nov 28, 2023

On-chain verification fails for recursive proofs noir-lang/noir#3166

Closed

Conversation

Maddiaa0 commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AztecBot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

Uh oh!

socket-security Bot commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LHerskind left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Maddiaa0 commented Nov 4, 2023

Uh oh!

LHerskind left a comment

Choose a reason for hiding this comment

Uh oh!

Savio-Sou commented Nov 22, 2023

Uh oh!

Maddiaa0 commented Nov 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Maddiaa0 commented Oct 31, 2023 •

edited

Loading

AztecBot commented Oct 31, 2023 •

edited

Loading

socket-security Bot commented Nov 3, 2023 •

edited

Loading

Maddiaa0 commented Nov 23, 2023 •

edited

Loading