Reimplement localization of page labels - #12
Conversation
There was a problem hiding this comment.
Seems like you're taking out the hard-coded localizations for 2.0...shouldn't the comment go too?
Or maybe I'm misunderstanding...the new code does much the same except not if there's already a data-i18n. Filling in the original text as a key does not feel to me like "adding hard-coded localizations" and we shouldn't be putting code that is only for 2.0 into our default branch, so something is wrong with this comment
There was a problem hiding this comment.
Yeah, I didn't really understand the comment. I thought maybe it meant that we are hard-coding it for 2.0 but would like to change that for the future. But I agree this isn't really hard-coded. I will remove the comment.
|
Seems like what this change actually does is to protect explicit localization keys from the hack we do to provide them when missing. I don't see any actual localization (or even new internationalization). |
|
This code was commented out because it had two problems.
I'll change the comment to reflect we are reimplementing localization for labels. |
andrew-polk
changed the title
022f202 to
c0ca062
Compare
Reimplement localization of page labels
#7949) Code changes responding to the PR review: - Team Collections (review #1/#3/#4/#13): BloomBridge's mutating external endpoints (add/update/process-book) now fail fast on a Team Collection rather than silently corrupting a shared collection (they don't honor checkout, the TeamCollection.status file, or TC renames). Adds CollectionModel.IsEditableCollectionATeamCollection and ExternalApi.RefuseIfTeamCollection, and documents the non-TC assumption on CollectionModel.AddBookFromFolder. - Off-screen JS bridge cleanup (#6/#7/#8) in BookProcessor: the capture trigger is now fire-and-forget (its result was discarded), the redundant Application.DoEvents() in the poll loop is removed (the sync call already pumps the loop), and WaitForJavascriptResult documents why the off-screen processor keeps the poll-a-window-global approach rather than the live editor's async API callback. - Async page-readiness (#10/#11/#15): SetImageDisplaySizeIfCalledFor now registers a requestPageContent delay around its asynchronous image-info fetch and resize, so captureContentForExternalProcessing waits for image sizing to finish before capturing. Corrects the editablePage.ts comments that wrongly called the load-time fix-ups "synchronous", and clarifies the natural-size fallback in autoFitImageOverTextSplits. - autoFit overlays (#14): fitOneImageOverTextSplit now also skips pages whose top pane has non-text overlays (canvas elements other than the background image), not just text overlays. - Smaller comment fixes: clarify the "already in the collection" guard in AddBookFromFolder (#2); document that the process-book overlay message is intentionally not localized (#12); note that priorForeground is captured once on purpose (#5); move the JSON-vs-delimiter note next to the code it describes (#16); raise the ExternalBusyOverlay z-index (#17). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
No description provided.