Add a few fields for I18N during New Collection Wizard - #4
Merged
Merged
Conversation
JohnThomson
added a commit
that referenced
this pull request
Oct 7, 2014
Add a few fields for I18N during New Collection Wizard
jsubloom
pushed a commit
to jsubloom/BloomDesktop
that referenced
this pull request
Jan 18, 2019
hatton
added a commit
that referenced
this pull request
Jun 26, 2026
#7949) Code changes responding to the PR review: - Team Collections (review #1/#3/#4/#13): BloomBridge's mutating external endpoints (add/update/process-book) now fail fast on a Team Collection rather than silently corrupting a shared collection (they don't honor checkout, the TeamCollection.status file, or TC renames). Adds CollectionModel.IsEditableCollectionATeamCollection and ExternalApi.RefuseIfTeamCollection, and documents the non-TC assumption on CollectionModel.AddBookFromFolder. - Off-screen JS bridge cleanup (#6/#7/#8) in BookProcessor: the capture trigger is now fire-and-forget (its result was discarded), the redundant Application.DoEvents() in the poll loop is removed (the sync call already pumps the loop), and WaitForJavascriptResult documents why the off-screen processor keeps the poll-a-window-global approach rather than the live editor's async API callback. - Async page-readiness (#10/#11/#15): SetImageDisplaySizeIfCalledFor now registers a requestPageContent delay around its asynchronous image-info fetch and resize, so captureContentForExternalProcessing waits for image sizing to finish before capturing. Corrects the editablePage.ts comments that wrongly called the load-time fix-ups "synchronous", and clarifies the natural-size fallback in autoFitImageOverTextSplits. - autoFit overlays (#14): fitOneImageOverTextSplit now also skips pages whose top pane has non-text overlays (canvas elements other than the background image), not just text overlays. - Smaller comment fixes: clarify the "already in the collection" guard in AddBookFromFolder (#2); document that the process-book overlay message is intentionally not localized (#12); note that priorForeground is captured once on purpose (#5); move the JSON-vs-delimiter note next to the code it describes (#16); raise the ExternalBusyOverlay z-index (#17). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.