Fix an error in NuGet.targets - #15
Merged
Merged
Conversation
The missing parenthesis prevents building with newer versions of MonoDevelop/xbuild.
andrew-polk
added a commit
that referenced
this pull request
Oct 8, 2014
Fix an error in NuGet.targets
hatton
added a commit
that referenced
this pull request
Jun 26, 2026
#7949) Code changes responding to the PR review: - Team Collections (review #1/#3/#4/#13): BloomBridge's mutating external endpoints (add/update/process-book) now fail fast on a Team Collection rather than silently corrupting a shared collection (they don't honor checkout, the TeamCollection.status file, or TC renames). Adds CollectionModel.IsEditableCollectionATeamCollection and ExternalApi.RefuseIfTeamCollection, and documents the non-TC assumption on CollectionModel.AddBookFromFolder. - Off-screen JS bridge cleanup (#6/#7/#8) in BookProcessor: the capture trigger is now fire-and-forget (its result was discarded), the redundant Application.DoEvents() in the poll loop is removed (the sync call already pumps the loop), and WaitForJavascriptResult documents why the off-screen processor keeps the poll-a-window-global approach rather than the live editor's async API callback. - Async page-readiness (#10/#11/#15): SetImageDisplaySizeIfCalledFor now registers a requestPageContent delay around its asynchronous image-info fetch and resize, so captureContentForExternalProcessing waits for image sizing to finish before capturing. Corrects the editablePage.ts comments that wrongly called the load-time fix-ups "synchronous", and clarifies the natural-size fallback in autoFitImageOverTextSplits. - autoFit overlays (#14): fitOneImageOverTextSplit now also skips pages whose top pane has non-text overlays (canvas elements other than the background image), not just text overlays. - Smaller comment fixes: clarify the "already in the collection" guard in AddBookFromFolder (#2); document that the process-book overlay message is intentionally not localized (#12); note that priorForeground is captured once on purpose (#5); move the JSON-vs-delimiter note next to the code it describes (#16); raise the ExternalBusyOverlay z-index (#17). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JohnThomson
added a commit
that referenced
this pull request
Jul 13, 2026
…book binding; session confound: both instances shared one collection copy (seat-proven); C# filter 430/430 post display-name work
JohnThomson
added a commit
that referenced
this pull request
Jul 13, 2026
A local book folder now resolves to its server row ONLY by its meta.json bookInstanceId -- never by folder name -- because "the status of a particular record by instanceID in the database is the source of truth for that book's state". This fixes both directions of the name-binding bug: - A checked-out book renamed locally (title change) stays bound to its own row, so it still shows as checked out (avatar, no false "available for editing") and no phantom not-yet-downloaded placeholder appears for its old name. - A local book that merely shares a NAME with a teammate's checked-in book (e.g. created offline) never wears that book's status, and PutBookInRepo can no longer check in over the other book: it resolves by instance id only, so the offline book correctly becomes a first-ever Send with the server's name-conflict suffix handling. The name index still serves repo-name queries (no local folder: GetBookList names, copy-down, placeholders), and GetRepoBookFile deliberately stays name-based per the base contract (NewBookRenamedFrom, GetRepoBooksByIdMap). RenameBookInRepo becomes a documented no-op (the pending-rename bridge map is redundant under identity resolution). Local instance ids are cached per folder, revalidated by meta.json timestamp+size, since status lookups run in tight loops. FolderTeamCollection is untouched: every change is a CloudTeamCollection override or the cloud-only placeholder merge in CollectionApi (which now also suppresses placeholders by local instance id). Tests: new CloudIdentityFirstLookupTests covering the rename and same-name conflict scenarios; placeholder suppression test; two OkToCheckIn fixtures now give their local folder its real meta.json identity; PolledChanges fake server made tolerant of the auto-apply background download its event triggers (pre-existing cross-thread flake). Filter incl. all folder-TC suites: 442/442. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing parenthesis prevents building with newer versions of
MonoDevelop/xbuild.