Skip to content

Add reusable CreateInfoBanner helper; fix Aura Filters banner links#57

Merged
DanderBot merged 3 commits into
DanderBot:mainfrom
Krathe82:fix/aura-filter-banner-overflow
May 11, 2026
Merged

Add reusable CreateInfoBanner helper; fix Aura Filters banner links#57
DanderBot merged 3 commits into
DanderBot:mainfrom
Krathe82:fix/aura-filter-banner-overflow

Conversation

@Krathe82

@Krathe82 Krathe82 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds GUI:CreateInfoBanner(parent, opts) — a self-sizing banner helper with tone presets (info / warning / caution / danger / success) that controls background colour, border, icon, and text colour. All banners now share a consistent look across the addon.
  • Replaces ad-hoc inline banner code in Aura Filters, Aura Blacklist, Aura Designer (sound alert), and Boss Debuffs pages with the new helper.
  • Uses a Button flow layout for HTML-mode banners (links + plain text), so OnClick dispatches reliably at any banner width. Text word-wraps to a new line when the window is narrow.
  • Banner height auto-resizes to fit content and triggers a host page re-layout so widgets below never overlap.

Test plan

  • Open Settings > Aura Filters — info banner shows, links navigate to correct pages, text wraps at narrow widths
  • Open Settings > Boss Debuffs — info banner shows, Dispel Overlays link navigates correctly
  • Open Settings > Aura Blacklist — warning banner shows and resizes correctly
  • Open Settings > Aura Designer > Sound Alert — warning banner shows
  • Open Settings > (any mode) > Sort — combat sort banner shows and changes tone between info/warning correctly
  • Open Settings > (any mode) > Buff Bars / Debuff Bars — debuff warning banner shows
  • Open Settings > Global Settings — info notice banner shows
  • Resize the addon window narrow — all banners reflow text without overflow

Krathe82 added 3 commits May 8, 2026 23:20
Introduces GUI:CreateInfoBanner — a self-resizing banner with tone
presets (info/warning/caution/danger/success) for consistent styling
across the addon. Uses a Button flow layout so clickable links dispatch
OnClick reliably and text word-wraps at any window width.

Replaces ad-hoc inline banners in Aura Filters, Aura Blacklist, Aura
Designer, and Boss Debuffs pages with the new helper. Also fixes the
Aura Filters info banner links which were not navigating when clicked.
@DanderBot DanderBot merged commit 4bd134c into DanderBot:main May 11, 2026
@DanderBot

Copy link
Copy Markdown
Owner

Thanks for the PR! Merged into main and will ship in the next alpha build.

DanderBot added a commit that referenced this pull request May 11, 2026
@Krathe82 Krathe82 deleted the fix/aura-filter-banner-overflow branch June 4, 2026 12:42
Krathe82 pushed a commit to Krathe82/DandersFrames that referenced this pull request Jun 6, 2026
…overflow

Add reusable CreateInfoBanner helper; fix Aura Filters banner links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants