Skip to content

(Personal Targeted Spells) Fix mover misaligned with icons in edit mode#69

Merged
DanderBot merged 1 commit into
DanderBot:mainfrom
Krathe82:fix/personal-targeted-spells-mover-alignment
May 11, 2026
Merged

(Personal Targeted Spells) Fix mover misaligned with icons in edit mode#69
DanderBot merged 1 commit into
DanderBot:mainfrom
Krathe82:fix/personal-targeted-spells-mover-alignment

Conversation

@Krathe82

@Krathe82 Krathe82 commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The edit mode mover box was misaligned with where Personal Targeted Spell icons actually appear. The mover's centre sat at icon 1's position, so the mover extended in the growth direction past the icons rather than surrounding them symmetrically.
  • The saved position (personalTargetedSpellX / Y) now represents the visual centre of the icon block. A new GetPersonalContainerPoint helper offsets the container by (maxIcons-1)/2 * (size+spacing) opposite to the growth direction, keeping icons centred on the saved point.
  • A one-time migration in Core.lua (MigratePersonalContainerPosition) shifts existing saved positions by the same halfBlock in the growth direction on first load, so icon 1 stays at its old screen location for existing users.
  • CENTER_H and CENTER_V growth directions are already symmetric and require no adjustment.

Test plan

  • Open Personal Targeted Spells edit mode — mover box should be centred on the icon block, not offset to one side
  • Drag the mover to a new position — icons follow correctly and mover stays aligned
  • Test each growth direction (LEFT, RIGHT, UP, DOWN, CENTER_H, CENTER_V) — mover aligns correctly in all cases
  • Reload after first fix application — existing saved position preserved visually (icon 1 stays where it was)

The saved position now represents the visual centre of the icon block.
The container is offset by half the block width/height opposite to the
growth direction, so the mover box and icons are correctly aligned.
A one-time migration shifts existing saved positions so icon 1 stays
at the same screen location after the update.
@DanderBot DanderBot merged commit 1c2438b into DanderBot:main May 11, 2026
@DanderBot

Copy link
Copy Markdown
Owner

Thanks for the PR! Merged into main and will ship in the next alpha build.

DanderBot added a commit that referenced this pull request May 11, 2026
@Krathe82 Krathe82 deleted the fix/personal-targeted-spells-mover-alignment branch June 4, 2026 12:42
Krathe82 pushed a commit to Krathe82/DandersFrames that referenced this pull request Jun 6, 2026
…pells-mover-alignment

(Personal Targeted Spells) Fix mover misaligned with icons in edit mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants