(Pet Frames) Fix RIGHT anchor misalignment in ATTACHED and GROUPED modes#71
Merged
DanderBot merged 1 commit intoMay 11, 2026
Merged
Conversation
In GROUPED+VERTICAL mode, the pet container was anchored to the bottommost party frame instead of the topmost, placing it below the party stack entirely. Fixed to use topmostFrame, mirroring the LEFT anchor case symmetrically. Also removes the -offsetX negation on all RIGHT anchor paths (ATTACHED, GROUPED+HORIZONTAL, GROUPED+VERTICAL) so that a positive Offset X value nudges the pet rightward (away from the party), consistent with how Offset X behaves in other anchor directions.
4 tasks
Owner
|
Thanks for the PR! Merged into main and will ship in the next alpha build. |
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
…hor-alignment (Pet Frames) Fix RIGHT anchor misalignment in ATTACHED and GROUPED modes
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related issues with the RIGHT pet anchor, both in
Frames/Pets.lua:1. GROUPED + VERTICAL: container anchored to wrong frame (main bug)
In
UpdatePetGroupLayout, theanchor == "RIGHT"+partyGrowth == "VERTICAL"branch was anchoring the pet container tobottommostFrameinstead oftopmostFrame. This placed the entire pet container below the party stack rather than alongside it. The LEFT anchor case correctly usestopmostFrame; this makes RIGHT symmetric with it.2. Inverted
offsetXsign on all RIGHT anchor pathsAll three RIGHT anchor
SetPointcalls used-offsetX, meaning a positive Offset X value moved the pet toward the owner rather than away from it. Fixed to useoffsetXdirectly (no negation), so positive Offset X consistently nudges the pet rightward (more gap) — the intuitive behaviour for an Offset X slider when the pet is positioned to the right.Affected paths:
PositionPetFrame— ATTACHED mode (line 704)UpdatePetGroupLayout— GROUPED + HORIZONTAL (line 886)UpdatePetGroupLayout— GROUPED + VERTICAL (line 888)Addresses the issue reported in https://discord.com/channels/1443538945605636149/1500157530763165696. Also supersedes PR #68 which fixes the
bottommostFrameissue alone.Test plan