chore: Merge 4.72.0 into master#7316
Merged
Merged
Conversation
Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com>
…ooting i18n key (#7119)
* feat: use file upload rest * code improvements * fix: tests * code improvements * fix: e2e test * chore: cleanup * fix: backward compatibilities * fix: tests * fix: tests * update mocks * comments
…older server (#7130) * chore: update filter * chore: code improvements * fix: workspace <3.16 hide system message switch * roomsHistoryRequest * fix: workspace > 3.16 hide system message switch * fix: tests * fix: lint * fix: code improvements * fix: unit test * code improvements * code improvements * fix: snapshot * fix: derive messagesIds ref inside useMemo to prevent stale data under concurrent rendering * fix: guard roomHistoryRequest dispatch to prevent re-firing on same loaderId * code improvements * code improvements
* feat: message a11y long press * chore: snapshot test * fix: e2e tests
* fix: inverted navigation * fix: just invert list content * fix: lint * test: inverted just in the inverted * fix: code * fix: invert just the flatlist content * fix: switch tab * try to reverse just the flatlist content * fix: inverted list direction * chore: format code and fix lint issues * fix: list issues * rollback List * revert unused changes on module * try native module approach * test: invert navigation * chore: format code and fix lint issues * space * fix: build * fix: keyboard navigation still working on different rooms * fix: last item focus * chore: format code and fix lint issues * fix: change focus * fix: lint * fix: merge issues * fix: lint * chore: format code and fix lint issues * rollback focus change * focus inside of roomView! * rollback: useScrollContainer * test: use a RNLike scrolview * fix: Pressable issues * fix: tests * use rectButton * update snapshot * fix: unit tests * fix: use Pressable to able to focus on iOS and keep it working on true sheet * chore: install react-native-external-keyboard * fix: focus on thread and reactions * feat: onThreadPress to open threads on keyboard * feat: usePressable gh * fix: gesture handler iOS focusable on keyboard * fix: patch package cleanup * fix: improve switch navigation * fix: tests * fix: test * fix: tests * fix: snapshot test * fix: tests * fix: snapshot * rollback * fix: test * fix: snapshot test * fix: lint * fix: podfile * fix: lock * fix: e2e tests * fix: tests * fix: i18n * chore: add commentsto reference invertedScrollView references * chore: rename archive * fix: remove fowardref * fix: remove fowardref * remove focusOnOpen * rename invertedScrollViewAdapter * fix: code issues * simplify invertedScrollViewAdapter * fix: snapshot * fix: imports * code improvements * chore: keyboard navigation test * feat: e2e tests batch * feat: e2e tests batch * fix: test * chore: keyboard-natigation-room test * device with keyboard navigation * rollback changs and fix test run on CI * ci(security): pin android-emulator-runner GitHub Action by SHA * fix: maestro running * external input module * fix: toolbar * fix: tests * fix: snapshot * fix: android keyboard build on gh actions * fix: test * fix: unit test * chore: code improvements * fix: test * improve tests * fix: snapshot * fix: e2e tests * fix: test * code improvements * usememo * rollback mainActivity * rollback mainActivity * fix: e2e tests * fix: keyboard test * fix: tests * fix: autofocus * replace requireNativeComponent * fix: tests * fix: tests * collapse children * fix(android): prevent inverted scroll content view from consuming taps * oly use customScrollview if has screenReader of keyboard enabled * fix: path * fix: focus dev mode * bump patch package --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com>
* test: new a11y experience of roomItem * feat: update snapshot * chore: format code and fix lint issues * action: organized translations * detect external keyboard module * cleanup Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * cleanup * cleanup * fix: onLongPress using rnExternalKeyboard * fix: iOS native module * fix: snapshot test * fix: snapshot conflict * code improvements * fix: minor bug * fix: snapshot test * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: formTextInput layout * fix: inappNotification test on iOS * fix: directory test * fix: snapshot test
Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com>
Resolve master ↔ develop conflicts on the release branch: - Version files kept at develop (4.72.0). - app/views/ChangePasscodeView.tsx, app/views/ScreenLockedView.tsx kept develop's layout — master's older centering CSS would reintroduce the regression fixed by #7118. - yarn.lock kept develop's (axios is 0.30.3 on both).
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Failure
Contributor
|
Important Review skippedToo many files! This PR contains 255 files, which is 105 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (45)
📒 Files selected for processing (255)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
had a problem deploying
to
official_ios_build
GitHub Actions
Failure
diegolmello
had a problem deploying
to
experimental_ios_build
GitHub Actions
Failure
diegolmello
had a problem deploying
to
experimental_android_build
GitHub Actions
Failure
diegolmello
had a problem deploying
to
official_android_build
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge
developintomasterfor the 4.72.0 release shipped to the App Store and Play Store.Built on a
4.72.0-masterrelease branch offdevelop, withmastermerged in to absorb 4.71.x hotfix history and resolve conflicts here (keepingdevelopclean).Conflict resolution:
package.json,android/app/build.gradle,ios/RocketChatRN/Info.plist,ios/ShareRocketChatRN/Info.plist,ios/RocketChatRN.xcodeproj/project.pbxproj) → 4.72.0.app/views/ChangePasscodeView.tsxandapp/views/ScreenLockedView.tsx→ develop's layout. Master's older centering CSS would reintroduce the regression fixed by regression: lock screen no longer appears full screen #7118.yarn.lock→ develop (axios is at 0.30.3 on both branches).Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2163
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments