Closed
Conversation
* fix: duplicate underline for search result titles on hover Added a rule to remove duplicate underline on hover for search result titles. * fix: undo Core-Styles link style in search suggestions Add styles to override core-styles for links in Google search suggestions. * fix: set color for Google magnifier icon * fix: google accent color on highlighted term Use TACC accent color not Google accent color on highlighted term.
The gray background matched parent background, so not visible. So, I fix it by making color darker.
- Should be style-dark and style-dark, not style-dark and style-light. - This code affects color that is already inherited as the same result.
This code is outdated. What it used to do is now done better by default styles. Retaining it causes less visual focus clarity.
Previous commit changes CSS. This comit saves our update live to use that new CSS via CDN.
This reverts commit 22dfb64.
This is the new way to do it. TUP CMS is the only client using old way.
These settings were moved in TACC/Core-CMS#v4.35.10
https://github.com/search?q=repo%3ATACC%2Ftup-ui%20%22%23page-portal%22&type=code The `page-` was forced in TACC/Core-CMS#v4.28 but not since TACC/Core-CMS#v4.29 https://github.com/TACC/Core-CMS/blob/v4.28.0/taccsite_cms/templates/base.html#L5 https://github.com/TACC/Core-CMS/blob/v4.29.0/taccsite_cms/templates/base.html
It works right on main branch… so, what happenned? Let's log a bit!
This reverts commit 683633e.
* refactor: simplify portal nav * docs: clearer explanation * docs: move comment * docs: clarify FAQ comment in nav_portal.raw.html
This reverts commit 2334cfc.
This reverts commit add55ed. incorrrect change. Edited code seems unused.
…until it is released, then use new release.
Has not been used for a while in favor of Core-CMS. Outdated since TACC/Core-CMS@89355dd6, in which COre-CMS brings over improvements this script had.
Keep aria-label like this only if "Published" is not in text e.g. ``` data-prefix="Published:" ```
Parent element reads <i class="icon…">` as a an odd character. Using `aria-hidden` isntead of `role` fixes that.
- delete plain.html (Core-CMS has it since #868) - delete duplicate footer social padding (now in c-footer.css) - delete outdated header font rule (Core-CMS has it since v4.25.1) Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Owner
Author
|
Tip This was A.I. working through an evaluation. See these instead: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
This was A.I. working through an evaluation.
See these instead:
Overview
Fix flagged accessibility issues.
Note
Reconcile with TACC#535:
→ No. Bugs found in refactor: deletions + changes for newer Core-CMS + Core-Styles TACC/tup-ui#535 are not in fix: a11y issues TACC/tup-ui#537:
nav_portal.raw.html: refactor: deletions + changes for newer Core-CMS + Core-Styles TACC/tup-ui#535 uses<a href="#">for the logged-in dropdown toggle; fix: a11y issues TACC/tup-ui#537 correctly uses<button>accent--normal(maps to#003399on light bg with new Core-Styles); fix: a11y issues TACC/tup-ui#537 usesaccent--light(maps to#3d6accon light bg) — correct→ No. Every relevant fix in refactor: deletions + changes for newer Core-CMS + Core-Styles TACC/tup-ui#535 is either already addressed differently in this PR or requires the full Core-CMS upgrade (refactor: deletions + changes for newer Core-CMS + Core-Styles TACC/tup-ui#535) that this PR intentionally skips:
adjust-logo.css): styles already present innavbar-width-horz-scrollbar.csslink.css: loaded here via npm package (github:TACC/Core-Styles#v2.54.0-rc1)PORTAL_STYLESsetting and Hotjar{% addtoblock %}: require Core-CMS v4.37.1+ (out of scope)→ Yes (and some of it does apply here — applied below). refactor: deletions + changes for newer Core-CMS + Core-Styles TACC/tup-ui#535 deletes many files now provided by the updated Core-CMS/Core-Styles it installs:
plain.html→ deleted here (Core-CMS has it since #868, which predatesfix-a11y-issues)paddinginnavbar-width-horz-scrollbar.css→ deleted here (now lives inc-footer.cssvia the footer a11y fix)navbar-width-horz-scrollbar.css→ deleted here (TODO said remove after v4.25.1; Core-CMS is v4.38.4+)assets_custom.html,open-external-post.html,admin/djangocms_icon/includes/assets.html— pending confirmation thatfix-a11y-issuesCore-CMS image includes those migrationsbreadcrumbs.js— pending confirmation as abovec-feed-list.css,s-breadcrumbs.css, removal ofc-feed-list-tweaks.cssCDN link — kept, Core-Styles v2.54.0-rc1 dist does not includec-feed-list, so the TUP override is still load-bearingSome fixes are cherry-picked from newer Core-CMS.1
Related
(this PR includes that PR's adaf981, 2d4a7f3, 2e36738, 7f57486, bffee57, 1892f2d, de6b56f, 56e9ef6)
Changes
SoftwareTablebutton & dialogrequiredfail,autocompletewrongTesting
(See TACC/tup-ui#537 Testing & UI — all items verified ✅)
Footnotes
Because upgrading would require more testing. ↩