[Upstream Catchup] Merge RC:master to master#36
Merged
Conversation
* Add ON_PRE_SETTING_UPDATE hook to apps * stage * Add new error type Toast.Error * Fix unit testing cases * Apply code review suggestions * Remove unused imports * Fix typos and add type annotations * format * Update definition * Fix unit testing * Use InvalidSettingValueException instead Toast.Error
* Start bridge refactor * Add description value to IRoom interface (RocketChat#380) * Remove old permission checkers * Add new bridge classes * Remove references to `proxy` code from the permission manager * Adjust types at bridges * Change the method for checking permissions and notify the errors * Rename exposed methods to use the permission methods * Add internal bridge interfaces * Cast methods from app manager related * Adjust spies on unit tests * Include the `delete room` method in the refactor * Update indentation based on reviewer's feedback * Switch from IUserBridge interface to UserBridge abstract class * Switch from IRoomBridge interface to RoomBridge abstract class * Switch from IPersistenceBridge interface to PersistenceBridge abstract class * Switch from ILivechatBridge interface to LivechatBridge abstract class * Switch from IMessageBridge interface to MessageBridge abstract class * Switch from IUploadBridge interface to UploadBridge abstract class * Switch from IHttpBridge interface to HttpBridge abstract class * Adjust argument type from delete room method * Switch from IEnvVarBridge interface to EnvVarBridge abstract class * Switch from IAppApiBridge interface to ApiBridge abstract class * Switch from IAppSchedulerBridge interface to SchedulerBridge abstract class * Switch from IAppCommandBridge interface to CommandBridge abstract class * Switch from IServerSettingBridge interface to ServerSettingBridge abstract class * Switch from IUiInteractionBridge interface to UiInteractionBridge abstract class * Switch from IAppDetailChangesBridge interface to AppDetailChangesBridge abstract class * Switch from IAppActivationBridge interface to AppActivationBridge abstract class * Rename SettingBridge to ServerSettingBridge * Adjustments based on linter hints * Rename permission check methods prefix from 'check' to 'has' * Adjust tests to work with bridges' abstract classes * Adjustments based on linter hints * Fix problems of lack of permissions in test suites Co-authored-by: thassiov <tvmcarvalho@gmail.com>
* Make the cloud interface a class and adjustmends * Fix reference of CloudWorkspaceBridge in the `bridges` module * Fix references of CloudWorkspaceBridge in accessors and tests
Shailesh351
approved these changes
Jul 15, 2021
|
Fantastic! Thanks @Shailesh351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly Catchup PR to merge RC:master in master.
Part of WideChat/Rocket.Chat#825