[cli] Fix output format of string by pulsar-admin command - #11878
Merged
Conversation
massakam
force-pushed
the
fix-pulsar-admin-output-format
branch
4 times, most recently
from
September 2, 2021 08:11
3039123 to
824f109
Compare
nkurihar
approved these changes
Sep 17, 2021
Member
|
Hi @tuteng Could you please help review this PR from the technical perspective? Thanks |
massakam
force-pushed
the
fix-pulsar-admin-output-format
branch
from
October 13, 2021 02:50
bbe19b4 to
e3c481c
Compare
massakam
force-pushed
the
fix-pulsar-admin-output-format
branch
from
October 14, 2021 02:10
e3c481c to
7dad9b0
Compare
tuteng
approved these changes
Oct 15, 2021
Contributor
|
@rdhabalia @sijie @merlimat It looks good to 2.4.2 or earlier users (including me). IMO the impact of this change is within only displayed messages and not large, so I approved. |
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 25, 2021
* up/master: (46 commits) [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (apache#12393) [docs] io-develop, fix broken link (apache#12414) docs(function): fix incorrect classname in python runtime sample (apache#12476) Remove redundant null check for getInternalListener (apache#12474) Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (apache#12451) [cli] Fix output format of string by pulsar-admin command (apache#11878) fix the race of delete subscription and delete topic (apache#12240) fix influxdb yaml doc (apache#12460) [Modernizer] Add Maven Modernizer plugin in pulsar-proxy module (apache#12326) fix DefaultCryptoKeyReaderTest can not run on windows (apache#12475) apache#12429 only fixed the compactor skips data issue, but the normal reader/consumer (apache#12464) broker resource group test optimize fail msg (apache#12438) Stop OffsetStore when stopping the connector (apache#12457) fix a typo in UnAckedMessageTracker (apache#12467) docs(function): fix typo in pip install (apache#12468) Optimize the code: remove extra spaces (apache#12470) optimize SecurityUtility code flow (apache#12431) Update lombok to 1.18.22 (apache#12466) Update team.js to add David K. as a committer (apache#12440) Fix java demo error in reset cursor admin (apache#12454) ... # Conflicts: # site2/website-next/versioned_docs/version-2.7.2/schema-evolution-compatibility.md # site2/website-next/versioned_docs/version-2.7.2/schema-get-started.md # site2/website-next/versioned_docs/version-2.7.2/schema-manage.md # site2/website-next/versioned_docs/version-2.7.2/schema-understand.md # site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
* Fix output format of list of strings by pulsar-admin command * Fix test code * Fix docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar version 2.4.2 and earlier, the pulsar-admin command output a list of strings in the following format:
On the other hand, in 2.5.0 and later versions, each string is enclosed in double quotes:
This is due to #5313. With this change, strings are now displayed after being encoded to JSON. I think these double quotes are superfluous.
Modifications
If the type of the variable to be output is
String, it will be output without JSON encoding.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes