Skip to content

Fix a typo in UnAckedMessageTracker - #12467

Merged
codelipenghui merged 1 commit into
apache:masterfrom
hezhangjian:typo-UnAckedMessageTracker
Oct 24, 2021
Merged

Fix a typo in UnAckedMessageTracker#12467
codelipenghui merged 1 commit into
apache:masterfrom
hezhangjian:typo-UnAckedMessageTracker

Conversation

@hezhangjian

@hezhangjian hezhangjian commented Oct 23, 2021

Copy link
Copy Markdown
Member

Motivation

Fix a typo in UnAckedMessageTracker.

Modifications

  • Fix a typo in UnAckedMessageTracker
  • Use Collections.addAll instead of manual for loop

Documentation

Need to update docs?

  • no-need-doc
    Little change, no need doc

@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli eolivelli added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 23, 2021
@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for providing doc info!

@hezhangjian

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Oct 24, 2021
@codelipenghui
codelipenghui merged commit 52336c8 into apache:master Oct 24, 2021
@hezhangjian
hezhangjian deleted the typo-UnAckedMessageTracker branch October 24, 2021 04:37
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 25, 2021
* up/master: (46 commits)
  [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (apache#12393)
  [docs] io-develop, fix broken link (apache#12414)
  docs(function): fix incorrect classname in python runtime sample (apache#12476)
  Remove redundant null check for getInternalListener (apache#12474)
  Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (apache#12451)
  [cli] Fix output format of string by pulsar-admin command (apache#11878)
  fix the race of delete subscription and delete topic (apache#12240)
  fix influxdb yaml doc (apache#12460)
  [Modernizer] Add Maven Modernizer plugin in pulsar-proxy module (apache#12326)
  fix DefaultCryptoKeyReaderTest can not run on windows (apache#12475)
  apache#12429 only fixed the compactor skips data issue, but the normal reader/consumer (apache#12464)
  broker resource group test optimize fail msg (apache#12438)
  Stop OffsetStore when stopping the connector (apache#12457)
  fix a typo in UnAckedMessageTracker (apache#12467)
  docs(function): fix typo in pip install (apache#12468)
  Optimize the code: remove extra spaces (apache#12470)
  optimize SecurityUtility code flow (apache#12431)
  Update lombok to 1.18.22 (apache#12466)
  Update team.js to add David K. as a committer (apache#12440)
  Fix java demo error in reset cursor admin (apache#12454)
  ...

# Conflicts:
#	site2/website-next/versioned_docs/version-2.7.2/schema-evolution-compatibility.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-get-started.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-manage.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-understand.md
#	site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
codelipenghui pushed a commit that referenced this pull request Oct 26, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 26, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants