Skip to content

Make DefaultCryptoKeyReaderTest can run on windows - #12475

Merged
merlimat merged 1 commit into
apache:masterfrom
hezhangjian:windows-ut-1024
Oct 24, 2021
Merged

Make DefaultCryptoKeyReaderTest can run on windows#12475
merlimat merged 1 commit into
apache:masterfrom
hezhangjian:windows-ut-1024

Conversation

@hezhangjian

@hezhangjian hezhangjian commented Oct 24, 2021

Copy link
Copy Markdown
Member

Motivation

Make DefaultCryptoKeyReaderTest can run on windows

Modifications

  • Make DefaultCryptoKeyReaderTest can run on windows
  • Fix a typo in SinkApiV3ResourceTest
  • Delete unused code in PrometheusMetricsTest

Documentation

Need to update docs?

  • no-need-doc

    little test change, no need doc

@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for providing doc info!

@eolivelli eolivelli added the doc-not-needed Your PR changes do not impact docs label Oct 24, 2021
@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli

Copy link
Copy Markdown
Contributor

@shoothzj:Thanks for providing doc info!

@merlimat merlimat added this to the 2.10.0 milestone Oct 24, 2021
@merlimat
merlimat merged commit bade5d7 into apache:master Oct 24, 2021
@hezhangjian
hezhangjian deleted the windows-ut-1024 branch October 24, 2021 23:18
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 25, 2021
* up/master: (46 commits)
  [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (apache#12393)
  [docs] io-develop, fix broken link (apache#12414)
  docs(function): fix incorrect classname in python runtime sample (apache#12476)
  Remove redundant null check for getInternalListener (apache#12474)
  Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (apache#12451)
  [cli] Fix output format of string by pulsar-admin command (apache#11878)
  fix the race of delete subscription and delete topic (apache#12240)
  fix influxdb yaml doc (apache#12460)
  [Modernizer] Add Maven Modernizer plugin in pulsar-proxy module (apache#12326)
  fix DefaultCryptoKeyReaderTest can not run on windows (apache#12475)
  apache#12429 only fixed the compactor skips data issue, but the normal reader/consumer (apache#12464)
  broker resource group test optimize fail msg (apache#12438)
  Stop OffsetStore when stopping the connector (apache#12457)
  fix a typo in UnAckedMessageTracker (apache#12467)
  docs(function): fix typo in pip install (apache#12468)
  Optimize the code: remove extra spaces (apache#12470)
  optimize SecurityUtility code flow (apache#12431)
  Update lombok to 1.18.22 (apache#12466)
  Update team.js to add David K. as a committer (apache#12440)
  Fix java demo error in reset cursor admin (apache#12454)
  ...

# Conflicts:
#	site2/website-next/versioned_docs/version-2.7.2/schema-evolution-compatibility.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-get-started.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-manage.md
#	site2/website-next/versioned_docs/version-2.7.2/schema-understand.md
#	site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants