[Doc] Fix wrong method call in admin demo code for reset cursor - #12454
Merged
Conversation
hangc0276
approved these changes
Oct 22, 2021
hangc0276
added
doc
tomscut
reviewed
Oct 22, 2021
tomscut
left a comment
tomscut
left a comment
Contributor
There was a problem hiding this comment.
Good catch. @hangc0276 @Jason918 Do we need to update admin-api-topics.md for multiple other versions?
codelipenghui
approved these changes
Oct 22, 2021
Contributor
|
@hangc0276 I have removed the 2.8.2 and 2.9.1 label because we are using the master branch to maintain all the document versions. |
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 25, 2021
* up/master: (46 commits) [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (apache#12393) [docs] io-develop, fix broken link (apache#12414) docs(function): fix incorrect classname in python runtime sample (apache#12476) Remove redundant null check for getInternalListener (apache#12474) Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (apache#12451) [cli] Fix output format of string by pulsar-admin command (apache#11878) fix the race of delete subscription and delete topic (apache#12240) fix influxdb yaml doc (apache#12460) [Modernizer] Add Maven Modernizer plugin in pulsar-proxy module (apache#12326) fix DefaultCryptoKeyReaderTest can not run on windows (apache#12475) apache#12429 only fixed the compactor skips data issue, but the normal reader/consumer (apache#12464) broker resource group test optimize fail msg (apache#12438) Stop OffsetStore when stopping the connector (apache#12457) fix a typo in UnAckedMessageTracker (apache#12467) docs(function): fix typo in pip install (apache#12468) Optimize the code: remove extra spaces (apache#12470) optimize SecurityUtility code flow (apache#12431) Update lombok to 1.18.22 (apache#12466) Update team.js to add David K. as a committer (apache#12440) Fix java demo error in reset cursor admin (apache#12454) ... # Conflicts: # site2/website-next/versioned_docs/version-2.7.2/schema-evolution-compatibility.md # site2/website-next/versioned_docs/version-2.7.2/schema-get-started.md # site2/website-next/versioned_docs/version-2.7.2/schema-manage.md # site2/website-next/versioned_docs/version-2.7.2/schema-understand.md # site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong method name in reset cursor admin doc.
Motivation
Fix typo.
Modifications
Change "skipAllMessages" to "resetCursor".
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docJust fixed typo in demo code, no code changed.