chore(astro): Add unstyled components by wobsoriano · Pull Request #3656 · clerk/javascript

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+  ...Astro.props
+}
+---
+
+<SignInButtonReact
+  client:load
+  {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+  btn.addEventListener("click", () => {
+    window.Clerk.signOut({ redirectUrl })
+  });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.

Also, looking at the SignOutButton reference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?

The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.

Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8 Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~ chore(astro): Add unstyled components Jul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to main July 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0 Compare July 4, 2024 15:57