Skip to content

[xcode14.2] Add ventura to mac tests configurations - #17945

Merged
rolfbjarne merged 8 commits into
dotnet:xcode14.2from
rolfbjarne:backport-17349-xcode14.2
Apr 11, 2023
Merged

[xcode14.2] Add ventura to mac tests configurations#17945
rolfbjarne merged 8 commits into
dotnet:xcode14.2from
rolfbjarne:backport-17349-xcode14.2

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Mar 30, 2023

Copy link
Copy Markdown
Member

Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349.

@dustin-wojciechowski @dalexsoto @rolfbjarne
[xcode14.2] Add ventura to mac tests configurations
c939e07 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of dotnet#17349.

---------

Co-authored-by: Alex Soto <alex@alexsoto.me>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne rolfbjarne mentioned this pull request Mar 30, 2023
Merged
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne
[monotouch-test] Ignore certificate chain errors on bots. Fixes #xama…
5616d33 
…rin/maccore@2626. (dotnet#16743)

Ignore certificate chain errors on bots in MessageHandlerTest.RejectSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler.

Fixes xamarin/maccore#2626.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne GitHub Actions Autoformatter
[tests] Ignore SWCollaborationView in DelegateAndSourceTest. (dotnet#…
c921af4 
…16777)

[SWCollaborationView setDelegate:] crashes when passed null.

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dalexsoto dalexsoto mentioned this pull request Apr 4, 2023
Merged
@rolfbjarne
[tests] Fix NSTextInputClient tests on macOS Ventura. (dotnet#17713)
50fc905 
Fixes:

    apitest.NSTextInputClient
        [FAIL] NSTextInputClient_ShouldGetBaselineDelta :   NSTextInputClient_ShouldGetBaselineDelta - Returned wrong baseline delta value
            Expected: True
            But was:  False
              at apitest.NSTextInputClient.NSTextInputClient_ShouldGetBaselineDelta () [0x0000e] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:108
        [FAIL] NSTextInputClient_ShouldGetFirstRect :   NSTextInputClient_ShouldGetFirstRect - Returned wrong rect
            Expected: {X=0,Y=0,Width=12,Height=14}
            But was:  {X=0,Y=0,Width=0,Height=14}
              at apitest.NSTextInputClient.NSTextInputClient_ShouldGetFirstRect () [0x00030] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:84
@rolfbjarne
[monotouch-test] Be more accepting in the NSTextInputClient test. (do…
6eedef1 
…tnet#17795)

It seems we can get different results depending on OS versions, but I had no
success figuring out the conditions that make the results differ, so just
accept all variations we get.
@rolfbjarne
Merge remote-tracking branch 'origin/xcode14.2' into backport-17349-x…
829e656 
…code14.2
@rolfbjarne
Merge remote-tracking branch 'origin/xcode14.2' into backport-17349-x…
8ee6dee 
…code14.2
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 350fe189f45d2b10c50d8db90de26d8c7cc8cf45 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 350fe189f45d2b10c50d8db90de26d8c7cc8cf45 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 350fe189f45d2b10c50d8db90de26d8c7cc8cf45 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Ventura
Hash: 350fe189f45d2b10c50d8db90de26d8c7cc8cf45 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
rolfbjarne merged commit d45953d into dotnet:xcode14.2 Apr 11, 2023
@rolfbjarne
rolfbjarne deleted the backport-17349-xcode14.2 branch April 11, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@tj-devel709 tj-devel709 tj-devel709 approved these changes
+2 more reviewers
@mandel-macaque mandel-macaque mandel-macaque approved these changes
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @tj-devel709 @haritha-mohan @dustin-wojciechowski