[Xcode 9] Update Metal for GM by timrisi · Pull Request #2689 · dotnet/macios

timrisi · 2017-09-13T21:54:00Z

No description provided.

spouliot · 2017-09-13T21:58:34Z

+#endif
+		[Export ("newRenderPipelineStateWithTileDescriptor:options:reflection:error:")]
+		[return: NullAllowed]
+		IMTLRenderPipelineState NewRenderPipelineState (MTLTileRenderPipelineDescriptor descriptor, MTLPipelineOption options, [NullAllowed] out MTLRenderPipelineReflection reflection, [NullAllowed] out NSError error);


CreateRenderPipelineState, e.g.

[Export ("newComputePipelineStateWithFunction:options:reflection:error:")] IMTLComputePipelineState CreateComputePipelineState (IMTLFunction computeFunction, MTLPipelineOption options, out MTLComputePipelineReflection reflection, out NSError error);

spouliot · 2017-09-13T21:58:41Z

+		[Abstract]
+#endif
+		[Async (ResultTypeName="NewRenderPipelineStateResult"), Export ("newRenderPipelineStateWithTileDescriptor:options:completionHandler:")]
+		void NewRenderPipelineState (MTLTileRenderPipelineDescriptor descriptor, MTLPipelineOption options, MTLNewRenderPipelineStateWithReflectionCompletionHandler completionHandler);


spouliot · 2017-09-13T21:59:12Z

 		IMTLDevice Device { get; }
+
+		[iOS (11, 0), TV (11,0), NoMac, NoWatch]
+		[Abstract]


that's an existing type, you cannot add abstract requirement on it

spouliot · 2017-09-13T21:59:20Z

+		nuint MaxTotalThreadsPerThreadgroup { get; }
+
+		[iOS (11, 0), TV (11,0), NoMac, NoWatch]
+		[Abstract]


spouliot · 2017-09-13T21:59:29Z

+		bool ThreadgroupSizeMatchesTileSize { get; }
+
+		[iOS (11, 0), TV (11,0), NoMac, NoWatch]
+		[Abstract]


spouliot · 2017-09-13T21:59:40Z

+		nuint ImageblockSampleLength { get; }
+
+		[iOS (11,0), TV (11,0), NoMac, NoWatch]
+		[Abstract]


monojenkins · 2017-09-14T01:07:57Z

Build failure

spouliot · 2017-09-14T01:48:05Z

@timrisi please double check the test failures

spouliot

Most of the new Metal stuff did not make it to tvOS (part of the test failures)

dalexsoto

Small thing

dalexsoto · 2017-09-14T02:54:10Z

+#if XAMCORE_4_0
+		[Abstract]
+#endif
+		[Async (ResultTypeName="NewRenderPipelineStateResult"), Export ("newRenderPipelineStateWithTileDescriptor:options:completionHandler:")]


Remove Async, it is not currently possible to do in Protocols

VincentDondain · 2017-09-14T16:17:21Z

Not sure we want to block the PR for that but we really should test MTLRenderCommandEncoder.cs, we're adding manual code without tests here.

VincentDondain · 2017-09-14T16:19:45Z


-		[Mac (10,13, onlyOn64: true)]
-		[NoTV][NoiOS]
+		[Mac (10,13, onlyOn64: true), iOS (11,0), TV (11,0)]


Minor but I try not to update existing availability attributes (diff noise) so I would have added [iOS (11,0), TV (11,0)] bellow the Mac one in replacement of [NoTV][NoiOS] (;

monojenkins · 2017-09-14T20:16:20Z

Build failure

spouliot · 2017-09-14T20:22:10Z

@timrisi looks like tests were not updated not to execute for tvOS

-tvOS - simulator (BuildFailure)
Project file: /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/monotouch-test/monotouch-test-tvos.csproj 
Platform: iPhoneSimulator Configuration: Debug 
Build duration: 00:00:10.6219051 
Main log
Build log
Metal/MTLTileRenderPipelineDescriptor.cs(17,3): error CS0246: The type or namespace name 'MTLTileRenderPipelineDescriptor' could not be found (are you missing a using directive or an assembly reference?) 
Metal/MTLTileRenderPipelineColorAttachmentDescriptorTests.cs(17,3): error CS0246: The type or namespace name 'MTLTileRenderPipelineColorAttachmentDescriptor' could not be found (are you missing a using directive or an assembly reference?) ```

monojenkins · 2017-09-14T21:50:33Z

Build success

monojenkins · 2017-09-15T00:08:38Z

Build failure

spouliot · 2017-09-15T00:08:55Z

build timed out (after 2 hours stuck)

spouliot · 2017-09-15T00:09:01Z

build

monojenkins · 2017-09-15T01:33:19Z

Build success

Bump maccore to bing the changes for governance and some others: * Merge 'xcode15' into 'main'. (dotnet#2690) * [Submission] Add NotaryTool Task (dotnet#2689) * [XmlDocSync] Remove the XmlDocSync reference from the project. (dotnet#2693) * [mlaunch] Refactor project structure (dotnet#2694) * [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12 (dotnet#2697) * [Governance] Update the false positives files based on the last runs. (dotnet#2698) Full idff: https://github.com/xamarin/maccore/compare/fd15821e6780a7439df467c69eb511a046adfa06...63fd14954ca3328219c5f79c754f0b329091535c

[Xcode 9] Update Metal for GM

2ea0c35

dnfclas added the cla-already-signed label Sep 13, 2017

spouliot suggested changes Sep 13, 2017

View reviewed changes

Make added abstracts XAMCORE_4_0, fix a couple method names

3d4f137

spouliot approved these changes Sep 14, 2017

View reviewed changes

spouliot suggested changes Sep 14, 2017

View reviewed changes

dalexsoto requested changes Sep 14, 2017

View reviewed changes

VincentDondain reviewed Sep 14, 2017

View reviewed changes

rolfbjarne approved these changes Sep 14, 2017

View reviewed changes

VincentDondain approved these changes Sep 14, 2017

View reviewed changes

Fix tests (and add some manual), Fix availability

d0dda2e

dalexsoto approved these changes Sep 14, 2017

View reviewed changes

spouliot approved these changes Sep 14, 2017

View reviewed changes

New monotouch-tests should be iOS only

e1c7d2e

Merge branch 'xcode9' into MetalGM

811108d

spouliot merged commit 46f4875 into dotnet:xcode9 Sep 15, 2017

mandel-macaque mentioned this pull request Aug 23, 2023

[Maccore] Bump to the latest main. #18799

Merged

Uh oh!

Conversation

timrisi commented Sep 13, 2017

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Sep 14, 2017

Uh oh!

spouliot commented Sep 14, 2017

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

dalexsoto Sep 14, 2017

Choose a reason for hiding this comment

Uh oh!

VincentDondain commented Sep 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VincentDondain Sep 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Sep 14, 2017

Uh oh!

spouliot commented Sep 14, 2017

Uh oh!

monojenkins commented Sep 14, 2017

Uh oh!

monojenkins commented Sep 15, 2017

Uh oh!

spouliot commented Sep 15, 2017

Uh oh!

spouliot commented Sep 15, 2017

Uh oh!

monojenkins commented Sep 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

VincentDondain commented Sep 14, 2017 •

edited

Loading

VincentDondain Sep 14, 2017 •

edited

Loading