[Intents] Fix watchOS INCarSeatResolutionResult breaking changes - #2690
Merged
Conversation
INCarSeatResolutionResult is not available in watchOS, unfortunately
it was bound pre xcode9 so until XAMCORE_4_0 happens it wont get removed
Type Changed: Intents.INCarSeatResolutionResult
Removed methods:
public static INCarSeatResolutionResult GetConfirmationRequired (INCarSeat valueToConfirm);
public static INCarSeatResolutionResult GetSuccess (INCarSeat resolvedValue);
spouliot
suggested changes
Sep 14, 2017
| #if XAMCORE_4_0 | ||
| [NoWatch] | ||
| #else | ||
| [Obsoleted (PlatformName.WatchOS, message:"'INCarSeatResolutionResult' is not available in watchOS.")] |
Contributor
There was a problem hiding this comment.
did Apple obsolete it ? or was it a binding mistake ?
Contributor
There was a problem hiding this comment.
rdar was filed, let's just remove the XAMCORE_4_0 (both sides)
Contributor
|
Build success |
spouliot
approved these changes
Sep 14, 2017
Contributor
|
Build success |
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Aug 23, 2023
Bump maccore to bing the changes for governance and some others: * Merge 'xcode15' into 'main'. (dotnet#2690) * [Submission] Add NotaryTool Task (dotnet#2689) * [XmlDocSync] Remove the XmlDocSync reference from the project. (dotnet#2693) * [mlaunch] Refactor project structure (dotnet#2694) * [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12 (dotnet#2697) * [Governance] Update the false positives files based on the last runs. (dotnet#2698) Full idff: https://github.com/xamarin/maccore/compare/fd15821e6780a7439df467c69eb511a046adfa06...63fd14954ca3328219c5f79c754f0b329091535c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INCarSeatResolutionResult is not available in watchOS, unfortunately
it was bound pre xcode9 so until XAMCORE_4_0 happens it won't get removed