[AVFoundation] Add missing types and categories. - #2694
Conversation
| } | ||
|
|
||
| [TV (11,0), NoWatch, Mac (10,13), iOS (11,0)] | ||
| [Protocol, Model] |
There was a problem hiding this comment.
The documentation isn't very clear about how this is used, so IMHO it would be best to remove [Model] (and [BaseType]) for now.
|
Build success |
|
|
||
| [Abstract] | ||
| [Export ("requestMediaDataWhenReadyOnQueue:usingBlock:")] | ||
| void RequestMediaData (DispatchQueue queue, Action block); |
There was a problem hiding this comment.
let us not use block as parameter name here, maybe handler?
There was a problem hiding this comment.
Hander is a valid choice, there are a lot of occurences of completionHandler or completion in our bindings but I don't think that's relevant here because of how the API works.
I would also suggest inputHandler based on this comment in the doc: "The block should append media data to the input" (https://developer.apple.com/documentation/avfoundation/avassetwriterinput/1387508-requestmediadatawhenreadyonqueue).
| [NullAllowed, Export ("error")] | ||
| NSError Error { get; } | ||
|
|
||
| [Mac (10, 13)] |
There was a problem hiding this comment.
This is not needed, the whole class is already [Mac (10, 13)]
|
|
||
| [Async] | ||
| [Export ("addPeriodicTimeObserverForInterval:queue:usingBlock:")] | ||
| NSObject AddPeriodicTimeObserver (CMTime interval, [NullAllowed] DispatchQueue queue, Action<CMTime> block); |
| NSObject AddPeriodicTimeObserver (CMTime interval, [NullAllowed] DispatchQueue queue, Action<CMTime> block); | ||
|
|
||
| [Export ("addBoundaryTimeObserverForTimes:queue:usingBlock:")] | ||
| NSObject AddBoundaryTimeObserver (NSValue[] times, [NullAllowed] DispatchQueue queue, Action block); |
|
Build failure |
VincentDondain
left a comment
VincentDondain
left a comment
There was a problem hiding this comment.
LGTM after Alex's comments are addressed.
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
please rebase this PR on xcode9.1 branch, thanks!
|
Closing branch since a new one with the new bindings for 9.1 will take over this work. |
|
New PR against Xcode9.1: #2919 |
Bump maccore to bing the changes for governance and some others: * Merge 'xcode15' into 'main'. (dotnet#2690) * [Submission] Add NotaryTool Task (dotnet#2689) * [XmlDocSync] Remove the XmlDocSync reference from the project. (dotnet#2693) * [mlaunch] Refactor project structure (dotnet#2694) * [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12 (dotnet#2697) * [Governance] Update the false positives files based on the last runs. (dotnet#2698) Full idff: https://github.com/xamarin/maccore/compare/fd15821e6780a7439df467c69eb511a046adfa06...63fd14954ca3328219c5f79c754f0b329091535c
7 participants
No description provided.