Allow loading gzipped profiles from more endpoints#5215
Merged
Conversation
- Move gzip handling to unserializeProfileOfArbitraryFormat method to enable proper handling of gzipped profiles from more endpoints - Fix tests which were incorrectly passing promise as payload instead of the compressed profile as ArrayBuffer.
nisargjhaveri
force-pushed
the
gzip_post_message
branch
from
e11172f to
72137d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5215 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 308 308
Lines 28059 28059
Branches 7598 7598
=======================================
Hits 24867 24867
Misses 2978 2978
Partials 214 214 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
|
Thanks, I've been wanting to do that for some time. We'll try to look at it shortly! |
julienw
reviewed
Dec 2, 2024
| const { getState, view } = await setupTestWithFile({ | ||
| type: '', | ||
| payload: compress(serializeProfile(profile)), | ||
| payload: (await compress(serializeProfile(profile))).buffer, |
Contributor
There was a problem hiding this comment.
is the problem that this was returned an UInt8Array but other APIs were wanting a ArrayBuffer?
Contributor
Author
There was a problem hiding this comment.
The problem was, this was returning promise whereas it was expecting ArrayBuffer. The promise was getting converted to empty object, which did not throw any errors as it went into some other path. Sorry, I don't recall the exact path it took now, but I understood it was not testing what we wanted.
julienw
approved these changes
Dec 2, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me.
Merged
canova
added a commit
that referenced
this pull request
Dec 12, 2024
[Sean Kim] Add Class of Service for a request in the profiler network tab (#5228) [Nisarg Jhaveri] Allow loading gzipped profiles from more endpoints (#5215) [Nicolas Chevobbe] Adapt Tree row toggle button to High Contrast Mode. (#5238) [Jon Coppeard] Display malloc heap size data in GCMajor markers (#5239) [Nicolas Chevobbe] Opt-out of forced-colors for colored-square and colored-border (#5237) [Yuval Mizrachi] Support colored bandwidth and memory tracks (#5232) [Nicolas Chevobbe] Adapt context menu to High Contrast Mode (#5244) [Nazım Can Altınova] Show Chrome extension instructions in the homepage if visited from Chromium browsers (#5251) And thanks to our localizers: de: Michael Köhler en-GB: Ian Neal fr: Théo Chevalier fr: felash fy-NL: Fjoerfoks it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy uk: Francesco Lodolo [:flod] uk: Markevych Dmytro Vitaliyovych zh-CN: Olvcpr423
tenderlove
pushed a commit
to tenderlove/profiler
that referenced
this pull request
Dec 21, 2024
…5215) - Move gzip handling to unserializeProfileOfArbitraryFormat method to enable proper handling of gzipped profiles from more endpoints - Fix tests which were incorrectly passing promise as payload instead of the compressed profile as ArrayBuffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5214