Skip to content

Opt-out of forced-colors for colored-square and colored-border#5237

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
nchevobbe:hcm-opt-out-forced-colors
Dec 4, 2024
Merged

Opt-out of forced-colors for colored-square and colored-border#5237
julienw merged 2 commits into
firefox-devtools:mainfrom
nchevobbe:hcm-opt-out-forced-colors

Conversation

@nchevobbe

Copy link
Copy Markdown
Member

We do want the color to be visible even if they're not system colors.

image
image

We do want the color to be visible even if they're not system colors.
@nchevobbe nchevobbe force-pushed the hcm-opt-out-forced-colors branch from 3da78e4 to 7bc84ac Compare December 2, 2024 09:47
@codecov

codecov Bot commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (8764e83) to head (7bc84ac).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5237   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         308      308           
  Lines       28059    28059           
  Branches     7598     7598           
=======================================
  Hits        24867    24867           
  Misses       2978     2978           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nchevobbe nchevobbe added the accessibility Related to making the profiler UI accessible label Dec 2, 2024

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienw julienw enabled auto-merge (squash) December 4, 2024 12:59
@julienw julienw merged commit 3b18ed2 into firefox-devtools:main Dec 4, 2024
@canova canova mentioned this pull request Dec 12, 2024
canova added a commit that referenced this pull request Dec 12, 2024
[Sean Kim] Add Class of Service for a request in the profiler network
tab (#5228)
[Nisarg Jhaveri] Allow loading gzipped profiles from more endpoints
(#5215)
[Nicolas Chevobbe] Adapt Tree row toggle button to High Contrast Mode.
(#5238)
[Jon Coppeard] Display malloc heap size data in GCMajor markers (#5239)
[Nicolas Chevobbe] Opt-out of forced-colors for colored-square and
colored-border (#5237)
[Yuval Mizrachi] Support colored bandwidth and memory tracks (#5232)
[Nicolas Chevobbe] Adapt context menu to High Contrast Mode (#5244)
[Nazım Can Altınova] Show Chrome extension instructions in the homepage
if visited from Chromium browsers (#5251)

And thanks to our localizers:
de: Michael Köhler
en-GB: Ian Neal
fr: Théo Chevalier
fr: felash
fy-NL: Fjoerfoks
it: Francesco Lodolo [:flod]
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
uk: Francesco Lodolo [:flod]
uk: Markevych Dmytro Vitaliyovych
zh-CN: Olvcpr423
tenderlove pushed a commit to tenderlove/profiler that referenced this pull request Dec 21, 2024
…ox-devtools#5237)

We do want the color to be visible even if they're not system colors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Related to making the profiler UI accessible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants