Show Chrome extension instructions in the homepage if visited from Chromium browsers#5251
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5251 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 308 308
Lines 28096 28105 +9
Branches 7619 7621 +2
=======================================
+ Hits 24899 24908 +9
Misses 2983 2983
Partials 214 214 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Dec 9, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me
flodolo
approved these changes
Dec 9, 2024
| own importer</write>. | ||
|
|
||
| Home--install-chrome-extension = Install the Chrome extension | ||
| Home--chrome-extension-instructions = Use the <a>{ -profiler-brand-name } Chrome Extension</a> |
Contributor
There was a problem hiding this comment.
Suggested change
| Home--chrome-extension-instructions = Use the <a>{ -profiler-brand-name } Chrome Extension</a> | |
| Home--chrome-extension-instructions = Use the <a>{ -profiler-brand-name } extension for Chrome</a> |
Might be slightly more readable?
Member
Author
There was a problem hiding this comment.
Sounds good to me! Changed it.
Member
Author
|
Thanks for the quick reviews! |
Merged
canova
added a commit
that referenced
this pull request
Dec 12, 2024
[Sean Kim] Add Class of Service for a request in the profiler network tab (#5228) [Nisarg Jhaveri] Allow loading gzipped profiles from more endpoints (#5215) [Nicolas Chevobbe] Adapt Tree row toggle button to High Contrast Mode. (#5238) [Jon Coppeard] Display malloc heap size data in GCMajor markers (#5239) [Nicolas Chevobbe] Opt-out of forced-colors for colored-square and colored-border (#5237) [Yuval Mizrachi] Support colored bandwidth and memory tracks (#5232) [Nicolas Chevobbe] Adapt context menu to High Contrast Mode (#5244) [Nazım Can Altınova] Show Chrome extension instructions in the homepage if visited from Chromium browsers (#5251) And thanks to our localizers: de: Michael Köhler en-GB: Ian Neal fr: Théo Chevalier fr: felash fy-NL: Fjoerfoks it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy uk: Francesco Lodolo [:flod] uk: Markevych Dmytro Vitaliyovych zh-CN: Olvcpr423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a Chrome extension, let's show an instruction to install it in the profiler home page if it's visited from Chromium based browsers.
I was also thinking about showing the recording instructions if we detect that the chrome extension is already installed, but I don't think we have to have that for the first iteration as this is a clear improvement to the previous version. I would prefer to implement that as a follow-up, as it will require changes in the extension code and we will have to publish that new extension version.
Screenshot: