Fix duplicate keybinding rule when replacing with an existing rule

[kridaydave]

In upsertKeybindingRule, the replace path only dropped the entry matching replaceTarget before appending the new rule. If that new rule already existed elsewhere in the config, the result contained a duplicate binding that survived downstream and got persisted.

The filter now also excludes any entry equal to the incoming rule, so it is appended exactly once. Added a regression test covering the case where the replacement rule already exists in the config.

---

Note

Low Risk
Narrow change to custom keybinding upsert/replace filtering plus a test; no auth, security, or broader API surface impact.

Overview
Fixes a bug in upsertKeybindingRule when replace is set: the config filter used to drop only the replace target, then append the new rule. If that new rule was already in the file, it stayed and was appended again, so duplicates were persisted.

The replace-path filter now also removes any entry equal to the incoming rule (same key/command/when) before append, so the rule is written once. A regression test covers replacing mod+r with mod+alt+r when mod+alt+r is already present.

^{Reviewed by Cursor Bugbot for commit 2bf2a05. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix duplicate keybinding rule when upserting with an existing replace target

When calling upsertKeybindingRule with a replace target, the new rule could be duplicated if it already existed elsewhere in the custom config. The fix extends the filter in keybindings.ts to remove entries matching either the replace target or the new rule before appending, ensuring only one instance appears in the persisted config.

^{Macroscope summarized 2bf2a05.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2839d8cd-73af-45cb-b704-9d223e97062e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved

Straightforward bug fix that prevents duplicate keybinding entries when replacing a rule with one that already exists. The change is minimal (one additional filter condition) with a clear test demonstrating the fix.

^{You can customize Macroscope's approvability policy. Learn more.}