#553 Replace /review-change with /review-branch and /review-pr - #570
Merged
Conversation
Convert the existing `review-change` skill into the focused `review-branch` skill. The skill now reviews the branch diff `merge-base(HEAD, <diff-base>)..HEAD` against an explicit `--diff-base=<ref>` flag (defaulting to the project's default branch). The previous `commit <ref>` positional and the entire commit-scope code path are removed: to review a specific commit or range, check out the desired commit and invoke `/review-branch --diff-base=<ref>~1`. Compilation, dependency installation, and test execution all require the working tree to match the commit being reviewed, so requiring a checkout is honest about the prerequisites and removes a redundant entry point.
The previous `ticket <source>` positional becomes `--ticket=<source>` for consistency with sibling skills. Ticket auto-resolution from the active run directory continues to work when `--ticket` is omitted.
The "Ticket compliance" section becomes "Specification compliance," structured as a list of `{ source_type, label, content, criteria? }` records. With zero sources the section is omitted (matching the prior "no ticket" behavior); with one source the rendered output is structurally identical to the previous single-ticket layout; with multiple sources the subsection repeats. This shape is the canonical input for `review-pr`, which appends the PR description as a `pr_description` source on top of the ticket source.
The skill body documents that `review-branch` is the canonical home of the shared review process and that `review-pr` invokes it after resolving platform-specific inputs, so future maintainers do not re-add the commit-scope path.
Introduce `/review-pr` as a user-invocable entry skill that reviews a pull request, alongside the internal `review-gh-pr` and `review-bb-pr` delegates that handle the platform-specific work. The new surface mirrors the established `create-pr` / `merge-pr` delegation pattern: the entry skill detects the platform, dispatches to the appropriate delegate to fetch PR metadata, verify HEAD, and resolve specification sources, then invokes the shared review process from `review-branch` with the prepared inputs.
`/review-pr` accepts a positional PR identifier (number or full URL) and the same `--diff-base=<ref>` and `--ticket=<source>` flags as `/review-branch`. Platform detection uses the cascade in `_data/ticket-source-resolution.md#platform-resolution-cascade`, with URL hosts overriding the cascade when a full URL is supplied. The delegate returns a resolved-input record (`merge_base_sha`, `diff_base`, `spec_sources`, `pr_metadata`) that the entry skill passes to `review-branch`'s review process — the entry skill itself runs no review logic.
`review-gh-pr` issues a single `gh pr view --json` call to fetch every needed field, then verifies HEAD against `headRefOid`. On mismatch, it exits with the literal `gh pr checkout {n}` suggestion so the user has a one-line fix. Ticket resolution follows the cascade `--ticket override → first closingIssuesReferences entry → PR body parse for closes/fixes/resolves/bare-hash references → none`. The PR description is always included as a `pr_description` source; the ticket is prepended when one is resolved.
`review-bb-pr` follows the same shape using the Bitbucket REST API at `api.bitbucket.org/2.0` and the same auth resolution as `bb-pr-inline-comment` and `create-bitbucket-pr` (no new client). Bitbucket Cloud's PR API does not expose a structured linked-issues field equivalent to GitHub's `closingIssuesReferences`, so the ticket-resolution cascade for the Bitbucket delegate is `--ticket override → PR body parse → none`. This divergence is documented in the skill body so future readers do not assume parity, and the cascade can grow a linked-issues step later without breaking the delegate interface. The HEAD-mismatch error message includes a Bitbucket-equivalent fetch-and-checkout pair.
The two specification sources (ticket + PR description) are listed `[ticket?, pr_description]` because the ticket is the higher-authority source — it states what was asked of the implementation, while the PR description presents what was delivered. Calling out divergence between the two is deferred to a follow-up ticket because it raises distinct design questions.
…iew-pr Replace `/review-change` references with the appropriate successor in the two skill files that mention it. In `wrap-up/SKILL.md`, the Review session-type signal now matches output from either `/review-branch` or `/review-pr`. In `save-artifact/SKILL.md`, the list of skills that produce run artifacts now references `review-branch`, since that skill is the canonical home of the shared review process and the only run-artifact-producing entry skill among the new surface (the `review-pr` entry skill itself does not save artifacts; it delegates artifact saving to `review-branch`). `_data/artifact-conventions.md` was audited and contained no live references to update. Historical entries in `CHANGELOG.md` and `.meta/changelog.json` are intentionally left untouched — those record what happened at the time of those releases.
Make the inter-skill contract between `review-pr` and `review-branch` self-describing for both invocation paths. In `review-pr`, expand step 1 to also obtain `ticket_ref` and `default_branch` from session context, and replace the terse "starting at step 4" instruction with explicit text stating that `review-branch`'s steps 1–3 are already complete: session context was gathered above and remains in scope, and `merge_base_sha` and `spec_sources` come from the delegate. In `review-branch`, add a note after step 3 documenting that when invoked by `review-pr`, the caller provides `merge_base_sha` and `spec_sources` so steps 2–3 are skipped.
Correct the `<pr_id>` argument description in `review-pr` from a misleading `{owner}/{repo}#{number}` shorthand notation (which `review-gh-pr` does not parse) to "Full GitHub or Bitbucket PR URL, or a bare PR number," matching what the delegates actually accept.
Replace the contradictory comment in the first usage example ("# Implicit PR id when the current branch has exactly one open PR.") — which conflicts with the explicit `1024` argument on the next line — with an accurate "# Check out the PR branch first, then review it."
Specify behavior in `review-branch`'s saving step when `ticket_id` is null: auto-generate a ticket id in the documented `{YYYYMMDD}-{4 random hex}` format from artifact-conventions.md, matching the project-wide convention used by `plan` and `plan-orchestrable-steps`. This prevents a literal `tickets/null/` path on branches with no recognizable ticket prefix.
Drop redundant boundary restatement, embedded maintainer rationale, and explanatory paragraphs that duplicated information already present in adjacent sections. In `review-gh-pr`, drop the "never produces findings, never saves..." sentence that restated the boundary already established by the first intro sentence and the `## Important` "No review logic here" bullet, and drop the trailing "Cache `merge_base_sha` for the resolved-output record." note since the variable's role is conveyed by the step 7 return-record spec. In `review-branch`, drop the two-sentence maintainer note about not re-adding a commit-scope path (the `--diff-base` flag in the Arguments table already communicates the commit-review escape hatch), and replace the redundant `get-session-context` call in the saving section with a back-reference to step 1. In `review-pr` step 5, compress the explanatory paragraph to a single sentence that retains the operational instruction and brief reason. In `review-bb-pr`, drop the two-sentence rationale paragraph after the fail-closed instruction in step 3, since the error message template already conveys the user-facing checkout path.
Move the "when invoked by review-pr" override blockquote to the top of the Process section so a linear executor sees it before running steps 2-3. Tighten the null-ticket fallback prose in the saving section.
Update the pr_id row in review-pr's delegate-input table to describe the actual division of labor: the orchestrator passes pr_id through verbatim, and the delegates parse URLs (with the Bitbucket delegate also auto-detecting workspace/repo from git remote). Drop create-bitbucket-pr from review-bb-pr's access-mechanism precedent reference. That skill is intentionally agnostic about access mechanism, so citing it as a REST-API precedent misrepresents its stance. The bb-pr-inline-comment reference is the accurate precedent.
williamthorsen
added
feature
Dependency auditProduction dependency audit passed. |
williamthorsen
marked this pull request as ready for review
May 10, 2026 17:33
williamthorsen
added a commit
that referenced
this pull request
Jul 18, 2026
…0.2.1 agents-v0.3.0 - #1019 feat: Add a personal rulebook with em-dash usage rule (#1024) - #1005 internal: Emit session-lifecycle events via harness hooks (#1021) - #1014 fix: Rebuild post-review next steps on the reviewer/author role model (#1020) - #1008 feat: Add a managed event-hook utility for Rovo config.yml (#1017) - #1004 feat: Add an implement-plan skill for the implementation phase (#1016) - #1009 fix: Sweep ticket and plan for missed decisions before saving (#1015) - #1007 internal: Add a managed hook-entry utility for Claude Code settings.json (#1011) - #1000 feat!: Rename and generalize the upgrade-dependencies skill (#1003) - #881 tooling: Migrate build to nmr-compile and give mcp an entry point (#1001) - #987 internal: Instrument review-branch, respond-to-review, and create-pr with lifecycle events (#999) - #986 internal: Add an emit-event skill helper and lifecycle event envelope v0 (#998) - deps: Upgrade all deps to latest minor version - #991 refactor: Remove client-side event-immutability enforcement (#997) - #993 refactor: Separate the smoke-test code from the bundle build tooling (#996) - #994 fix: Remove the visualization hooks that logged an error on every prompt (#995) - #740 fix: Recommend refine-plan only when decisions remain unsettled (#990) - #989 refactor: Give the store's on-disk layout a single owner (#992) - #973 fix: Carry comment discipline in every agent that writes comments (#983) - #978 feat: Add an action-items convention that separates asks from prose (#982) - #972 fix: Support events from a harness that exposes no session id (#981) - #971 fix: Inline output-shaping specs so skills cannot improvise them (#980) - #976 feat!: Disambiguate the memory-store selector and accept its displayed label (#979) - #927 feat: Frame agent-guidance changes as instructions, not accomplished behavior (#970) - #964 feat: Default to folding discovered work into the current change (#969) - #962 feat: Standardize ticket-authoring doctrine across the emitting skills (#968) - #958 refactor: Route the capture-event add path through KbEvent (#966) - #853 refactor: Replace rule engine with a type-blind vault-integrity layer (#961) - #852 refactor: Route the assertion write commands through KbAssertion (#959) - #907 fix: Render self-referential and cross-skill invocations per harness (#957) - #953 feat: Resolve the PR URL from a PR-based branch identity (#956) - #914 feat: Add spike mode to the ticket and plan authoring skills (#955) - #950 feat: Support a PR number as a branch and artifact identifier (#954) - #938 feat: Support collections from user-declared content sources (#951) - #939 fix: Dedup migrated memories by topic, not session id alone (#949) - #919 feat: Keep implementation detail out of ticket drafts (#948) - #933 feat: Report the source each deployed artifact resolved from (#947) - #940 feat: Add a feedback-memories list command and rename the toolbox (#946) - #932 feat: Support skills and subagents from user-declared content sources (#945) - #936 fix: Attribute migrated feedback events to their origin project (#942) - #934 refactor: Narrow resolveClosure to SourceResolver only (#941) - #924 feat: Resolve rulebooks from user-declared content sources (#935) - #859 feat: Scope feedback-memory migration per store and ground triage in each project (#931) - #650 feat: Add migrate-feedback-memories skill to route memories home (#930) - fix: Special-case the # prefix in create-ticket id construction - #721 feat: Route generalizable feedback to capture-feedback, not memory (#929) - #847 fix: Prevent create-ticket from mis-associating backlog tickets (#928) - #922 feat: Default interactive chat to concise with deep-dive opt-in (#926) - #921 feat: Extend compose-time concision to plans, devlogs, summaries (#925) - docs: Add ambient-hosts to guidance README - #920 feat: Establish the concision spine and wire the ticket and review-comment gates (#923) - #883 tests: Run real-install tests only as a deliberate integration step (#917) - #751 refactor: Set the shell-conventions rulebook to skill-only delivery (#916) - #886 feat!: Deploy harness-specific skills via the declarative mechanism (#912) - #877 feat: Generate project-scoped Rovo Dev prompts.yml on sync (#911) - #904 feat: Make events editable until pushed to the remote (#910) - #879 fix: Declare cross-artifact runtime dependencies (#908) - #897 feat: Surface event impact in recall and filter by it (#906) - #898 feat: Add `{skill:}` and `{subagent:}` invocation tokens (#905) - #899 fix: Skip support directories with no installable files (#903) - #821 feat: Add a mutable impact rating to events (#901) - #895 fix: Deploy a subagent's injected skills with sync (#900) - fmt: Auto-format - #880 feat: Add authoring-guidance rulebook for agents (#896) - #878 feat!: Retire unconditional install (#894) - #892 feat: Apply skill transforms when sync deploys declared skills (#893) - #888 feat: Resolve and persist ticket URLs for bare or omitted references (#890) - #887 feat: Add collection members key with computed @library membership (#889) - #857 feat: Add a user-global deployment domain via sync --global (#884) - #871 feat: Add capture-feedback skill (#882) - #856 feat: Add collections and transitive dependency resolution (#876) - #855 feat: Make subagents declarable and deployable via codeassembly.yaml (#875) - #854 feat!: Make skills declarable & deployable via codeassembly.yaml (#873) - #851 feat: Add kb-retrieve-events for event recall (#872) - #865 tests: Rationalize install-command tests onto fixtures to remove timeout flakes (#870) - #860 feat: Add library list command to enumerate artifacts (#868) - #850 feat: Add kb-update-events for batch event editing (#867) - #733 feat!: Introduce the codeassembly.yaml rulebook declaration format (#866) - #843 fix: Wire comment-discipline into respond-to-review (#845) - #834 fix: Remove dangling owned symlinks during uninstall (#844) - #830 feat: Name skill-delivered rulebooks with a consult- prefix (#839) - #833 fix: Make a no-findings review a valid, full-score result (#838) - #827 feat: Rename collaboration skill to collaborate and make it user-invocable (#837) - #828 fix: Prune stale files on install (#836) - #820 feat!: Rename platform to harness (runtime) and scm (VCS host) (#832) - #824 fix: Scope kb-retrieve recall to the configured note set (#829) - #818 tests: Use full timestamps in test fixtures, not bare dates (#826) - #816 fix: Write kb-add assertions under content/assertions (#819) - #813 fix: Stop --retag from bumping updated for curatorial tag edits (#823) - #817 feat: Record the agent harness in captured events (#822) - #802 fix: Gate kb-add's registry default behind an explicit @default sentinel (#814) - #775 feat: Default ticket-emitting skills to concise tickets (#811) - #785 feat: Add a kb-edit operation to append addressed-by references (#808) - #784 fix: Stop reviewers emitting self-disqualifying findings (#804) - #800 fix: Require an explicit --store on every capture-event call (#806) - #803 fix: Repair collaboration skill's mistake-recording step (#805) - #796 refactor: Rename PlatformConfig dir-name fields to *DirName (#801) - #791 fix: Expand templated script paths in installed subagents (#797) - #783 feat: Store and reuse resolved ticket and PR URLs in the branch manifest (#789) - #780 fix: Exclude top-level skills/_partials/ from skill installation (#788) - #763 feat: Add an addressed-by/addresses relation linking problems to their responses (#787) - #779 feat!: Designate the default KB with a top-level default_kb pointer (#786) - #774 feat: Unify plan and design-and-plan on a shared plan template (#782) - #771 refactor: Consolidate duplicated parseTagList and readAll helpers (#781) - #766 feat!: Adopt explicit-UTC second-precision timestamps for KB date fields (#773) - tests: Drop the removed immutable field from a kb-retrieve helper - #749 feat: Honor the schema recall policy in kb-retrieve (#764) - #748 refactor: Remove the unused immutable record-type schema flag (#765) - #756 feat: Rename the Diátaxis --type flag to --diataxis (#757) - #720 feat: Add a kb create command to provision new KB stores (#755) - #732 feat: Add skill delivery mode for rulebooks (#754) - #741 fix: Resolve review spec source by recency with an explicit override (#753) - #734 refactor: Replace js-yaml with the yaml library (#743) - #727 refactor: Redesign the record taxonomy around a stored recordType discriminant (#742) - #731 feat: Add init and sync commands for the project rulebook library (#738) - #718 feat: Add a config-driven kb check CLI and library export (#735) - #724 refactor: Rename @codeassembly/kb-core to @codeassembly/kb (#726) - #715 fix: Drop branch-cleanup advice and deletion-status fields from merge output (#722) - #716 feat: Relocate event records to content/events/ and document the fix-tag convention (#719) - #714 feat: Add event capture and a kind-aware record-store core (#717) - deps: Upgrade all deps to latest minor version - #706 fix: Reframe legacy finding-ID rule to prevent ID collisions (#712) - #709 feat: Skip HTML sanitization for the markdown Jira-update tool (#710) - #704 fix: Give the lede pipeline authority to cut supplied mechanism (#708) - #702 refactor: Deduplicate the isRecord type guard across factory and run-core (#707) - #661 fix: Self-anchor agents helpers at the git repo root (#703) - #690 refactor: Deduplicate filesystem-existence and type-guard helpers (#700) - #684 test: Pin --kb resolution for a single-entry default registry (#698) - #689 feat: Consolidate the kb.yaml loader and surface registry defects in kb-retrieve (#695) - #683 fix: Forbid interactive UI controls when prompting the user (#692) - #685 refactor: Consolidate acceptance-criteria scaffold into a partial (#691) - #670 fix: Keep change-summary ledes outcome-shaped (#688) - #671 feat: Treat suppression directives as reviewable design signals (#686) - #678 fix: Stop resolving the pr field at artifact-write time; set it only in PR-aware skills (#687) - #638 feat: Add kb-curate skill for vault-wide KB hygiene (#681) - #662 feat: Add /revise-comments to audit and edit existing comments (#680) - #674 fix: Tighten review-finding thresholds for genuine improvements (#679) - #673 feat: Add kb-edit skill for post-creation note maintenance (#676) - #672 fix: Move user-global KB config to `~/.agents/kb.yaml` (#675) - #657 feat: Add test-structure discipline to agent guidance and review pipeline (#669) - #658 fix: Fix `&` corruption in rendered titles on bash 5.2+ (#667) - #664 fix: Tolerate unknown keys in `.agents/preferences.yaml` (#666) - #653 fix: Replace `get-session-context` skill with a bundled TS deriver (#663) - #642 feat: Add comment discipline to agent guidance and review pipeline (#659) - #643 fix: Add update-jira-ticket pre-flight validator and rework recovery protocol (#654) - #637 feat: Add kb-add skill for capturing knowledge-base notes (#652) - #636 feat: Add kb-retrieve skill for querying the knowledge base (#645) - #629 fix: Skip .DS_Store and stray entries during rovodev install (#633) - #631 fix: Make installable content paths resolve outside the monorepo (#632) - #567 feat: Surface ticket-vs-PR-description divergence in /review-pr (#628) - #624 fix: Make resolve-frontmatter work from any subdirectory (#627) - #621 fix: Codify dispatch precondition for resolve-frontmatter (#626) - #592 feat: Apply recommendation gradient to all substantive option choices (#625) - #558 feat: Add changelog-writer subagent (#620) - #617 fix: Make skill tool-name references platform-portable (#619) - #603 tests: Add edge-case tests for artifact-frontmatter YAML emission (#618) - #599 feat: Decouple review dispositions from reviewer framing (#616) - #611 feat: Stop reporting "behavior unchanged" in changelog entries (#615) - #608 feat: Discourage code-level detail in design-and-plan tickets (#614) - #607 fix: Use {platform_home_dir} for helper-script invocations (#613) - feat: Add guidance about capitalization after a colon - deps: Upgrade all deps to latest minor version - #606 tooling: Allow test:sh to run selected shellspec tests (#610) - #605 fix: Fix shellspec test suite hangs in agents package (#609) - #595 refactor: Emit complete YAML frontmatter from resolve-frontmatter.sh (#604) - #593 feat: Add change-narrating voice and jargon to lede-voice (#602) - #597 feat: Make subagent tool-name references platform-portable (#601) - refactor: Fix capitalization in subagent definitions - #572 feat: Revise `respond-to-review` to be less deferential to reviewer recommendations (#600) - #589 feat: Guide agents to prefer partials over duplicated content (#598) - #537 feat: Unify artifact frontmatter under a canonical metadata schema (#596) - #583 feat: Require repo-relative paths in review finding locations (#594) - #581 feat: Redefine 👍🏼👎🏼 as a confirmation contract (#586) - #584 fix: Remove `<pre>` from update-jira-ticket allowlist (#585) - feat: Strengthen type-safety guidance - #580 fix: Restore gradient usage with skill-local pointers (#582) - #578 fix: Prohibit `version_message` argument in update-jira-ticket (#579) - #555 feat: Restructure voice and format rules to enforce inline at point-of-use (#573) - #522 feat: Support partials in skills and subagent definitions (#571) - #553 feat: Replace /review-change with /review-branch and /review-pr (#570) - #515 feat: Auto-retry interrupted reviewer dispatches (#566) - #519 fix: Raise reviewer max_turns defaults (#564) - #560 feat: Treat tickets as requests; design as if from the beginning (#562) - #544 fix: Stop under-recommending direct implementation (#557) - #548 feat: Add work-type emojis and breaking tag to PR descriptions (#554) - #542 refactor: Stop duplicating work-type tiers in commit/SKILL.md (#551) - #545 feat: Add critical-evaluation guidance to collaboration skill (#550) - #538 feat: Extract release-notes voice into shared rules (#549) - #540 refactor: Remove duplicated rules from shared AGENTS.md (#547) - #536 fix: Treat menu omission as drop in /wrap-up (#541) - #535 feat: Inline shared guidance into platform files at install time (#539) - #524 feat: Document code+mark restriction in update-jira-ticket (#534) - #531 feat: Delimit publishable content in merge approval prompt (#533) - #526 feat: Make recommendation-gradient the interactive default (#532) - #469 internal: Migrate label-map schema reference to release-kit (#530) - ## tooling: Exclude generated files from Prettier formatting - #527 refactor: Unify Jira-style ticket ID extraction across skills (#529) factory-v0.2.1 - deps: Upgrade all deps to latest minor version - #943 docs: Remove local-only references from design docs (#944) - fmt: Auto-format - deps: Upgrade all deps to latest minor version - #818 tests: Use full timestamps in test fixtures, not bare dates (#826) - deps: Upgrade jsdom to patch vuln in undici - deps: Upgrade all deps to latest minor version - deps: Upgrade all deps to latest minor version - #702 refactor: Deduplicate the isRecord type guard across factory and run-core (#707) - deps: Upgrade all deps to latest minor version - deps: Upgrade all deps to latest minor version - deps: Upgrade dependencies - ## tooling: Exclude generated files from Prettier formatting kb-v0.2.0 - #881 tooling: Migrate build to nmr-compile and give mcp an entry point (#1001) - deps: Upgrade all deps to latest minor version - #989 refactor: Give the store's on-disk layout a single owner (#992) - #972 fix: Support events from a harness that exposes no session id (#981) - #965 tooling: Fix type resolution in the published kb and run-core packages (#975) - #853 refactor: Replace rule engine with a type-blind vault-integrity layer (#961) - #852 refactor: Route the assertion write commands through KbAssertion (#959) - #821 feat: Add a mutable impact rating to events (#901) - fmt: Auto-format - #851 feat: Add kb-retrieve-events for event recall (#872) - #850 feat: Add kb-update-events for batch event editing (#867) - #849 internal: Add type-blind note I/O and declared per-type record modules (#858) - #824 fix: Scope kb-retrieve recall to the configured note set (#829) - #818 tests: Use full timestamps in test fixtures, not bare dates (#826) - #817 feat: Record the agent harness in captured events (#822) - #800 fix: Require an explicit --store on every capture-event call (#806) - #792 feat: Set the default knowledge base when creating one (#799) - #793 feat: Add a kb set-default command for the default knowledge base (#798) - #763 feat: Add an addressed-by/addresses relation linking problems to their responses (#787) - #779 feat!: Designate the default KB with a top-level default_kb pointer (#786) - #766 feat!: Adopt explicit-UTC second-precision timestamps for KB date fields (#773) - #767 refactor: Normalize declaration ordering across the kb package (#770) - #761 feat: Add note targeting to kb check via paths and --vs (#769) - #748 refactor: Remove the unused immutable record-type schema flag (#765) - #759 feat: Alphabetize the default schema's field lists and add diataxis to assertion (#760) - #752 refactor: Consolidate duplicated kb test helpers into a shared module (#758) - #720 feat: Add a kb create command to provision new KB stores (#755) - #727 refactor: Redesign the record taxonomy around a stored recordType discriminant (#742) - kb: Fix executable bit of kb script - #718 feat: Add a config-driven kb check CLI and library export (#735) - #724 refactor: Rename @codeassembly/kb-core to @codeassembly/kb (#726) mcp-v0.2.1 - #881 tooling: Migrate build to nmr-compile and give mcp an entry point (#1001) - ## tooling: Exclude generated files from Prettier formatting run-core-v0.2.1 - #881 tooling: Migrate build to nmr-compile and give mcp an entry point (#1001) - #965 tooling: Fix type resolution in the published kb and run-core packages (#975) - #818 tests: Use full timestamps in test fixtures, not bare dates (#826) - #734 refactor: Replace js-yaml with the yaml library (#743) - deps: Upgrade all deps to latest minor version - #702 refactor: Deduplicate the isRecord type guard across factory and run-core (#707) - ## tooling: Exclude generated files from Prettier formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Code review now has two commands.
/review-branchreviews the current branch against a diff base;/review-pr <id>reviews a pull request and evaluates the implementation against both the linked ticket and the PR description. Both accept--diff-base=<ref>(default: project's default branch) and--ticket=<source>(default: auto-resolved). The previous/review-changeis removed; to review a specific commit, check it out and run/review-branch --diff-base=<ref>~1.Why
The single-entry
/review-changecovered three scenarios — pre-PR branch review, remote PR review, and arbitrary commit/range review — distinguished only by verbose argument suffixes. The most common case (review of the current branch before opening a PR) required a long, ceremony-laden invocation, and a stacked-PR review forced users to remember and articulate that the default diff base no longer applied. Splitting into two commands with names that match their actual scope, plus standardizing on the--diff-base=<ref>flag already used by sibling skills, makes the dominant case fast and the others uniformly expressible.Details
🎉 Features
/review-pr <id>(new, user-invocable): accepts a positional PR identifier (full URL or bare PR number), supports--diff-base=<ref>and--ticket=<source>, and detects the platform via the cascade in_data/ticket-source-resolution.md#platform-resolution-cascade. Dispatches toreview-gh-pr(GitHub) orreview-bb-pr(Bitbucket) for platform-specific work — PR-metadata fetch, HEAD verification, ticket resolution from PR linked issues, and spec-source preparation — then invokesreview-branch's shared review process with the resolved inputs./review-prruns, the "Specification compliance" section renders one row per available source: the resolved ticket (if any) and the PR description. Each source is evaluated independently against the implementation. The previous "Ticket compliance" rendering is preserved when only one source is available, so the single-ticket case looks structurally identical to the prior output.git rev-parse HEADagainst the PR's head commit and exit non-zero on mismatch with a copy-pasteable checkout suggestion:gh pr checkout <n>for GitHub;git fetch origin pull-requests/<n>/from:pr-<n> && git checkout pr-<n>for Bitbucket. Compilation, dependency installation, and test execution all require the working tree to match the commit being reviewed — proceeding with mismatched state is never useful.review-branchis invoked on a branch with no derivable ticket, the saving step generates a ticket directory in the format{YYYYMMDD}-{4 random hex}per the convention inartifact-conventions.md#ticket-id. Previous behavior would have constructed a literaltickets/null/path.♻️ Refactoring
review-change→review-branch(renamed and simplified). Drops the commit-scope path entirely (now recoverable viagit checkout <ref> && /review-branch --diff-base=<ref>~1). Converts the previousticket <source>positional argument to--ticket=<source>for consistency with sibling skills. Renames the "Ticket compliance" section to "Specification compliance" with a list-driven rendering (zero, one, or many sources).merge-pr/create-prdelegate pattern but inverts the locus of shared logic: instead of putting shared work in the entry skill (asmerge-prdoes), the shared review process lives in the user-invocablereview-branchbecause branch review is itself a primary surface. Bothreview-branchandreview-prdocument this explicitly so future maintainers don't accidentally re-fragment the logic or re-add the commit-scope path.📚 Documentation
/review-changereferences inwrap-up/SKILL.mdandsave-artifact/SKILL.mdwith the appropriate successor (/review-branchand/or/review-pr). Historical entries inCHANGELOG.mdand.meta/changelog.jsonare preserved verbatim — those record what happened at the time.review-bb-pr/SKILL.md. Bitbucket Cloud has noclosingIssuesReferencesequivalent, so the Bitbucket ticket-resolution cascade has 3 steps (override → PR-body parse → none) compared to GitHub's 4 (override → linked issues → PR-body parse → none).Closes #553