Add dynamic type support - #20342
Conversation
|
Hi @staskus As I mentioned in the example in the post, the dynamic type solution does not work for some languages with long field names. I proposed an alternative solution to hide the website for a larger font size set up, but that might need some times for discussion. Therefore, I suggest we focus on other tasks first, and I will submit another PR for UI update once we have a better solution. What do you think? |
|
Change to horizontal layout for larger size category
6582fdb to
79ae005
Compare
Great, then I think we can move on to the next task based on the existing layout. I will revisit this feature once we have a better solution from further discussion. I have extracted the translation part from this pull request to another one: #20353. |
|
@tzef Thanks. I will take a look at another PR. This PR could be switched to a "Draft" while its direction is unclear. |
This PR is for improving the comments for previous PR #20312
(Confirm the data display on UI correctly in this phase)
Description
To add dynamic type support to the widget view, we need
First, replace the fixed-size font with the dynamic font. I chose the font with the same size as the design based on the typography document.
Second, add a horizontal layout for the size category larger than large, as we discussed in PR #20312 . The existing font already be the maximum font size, so I change the layout to get available spaces as the temporary solution, and I will compose a post to clarify with the design team in the meanwhile.
Testing instructions
Given added the widget to the lock screen, changed the size category in Settings > Display and Brightness > Text Size
The font size and layout should be changed based on the font size (the result could refer to the above preview screenshot)
Regression Notes
Potential unintended areas of impact
The UI representation for today views the widget in the lock screen
What I did to test those areas of impact (or what existing automated tests I relied on)
Check the design is still good (I will double confirm with the designer)
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.