Add localizable string for "Views Today" title by tzef · Pull Request #20353 · wordpress-mobile/WordPress-iOS

tzef · 2023-03-17T01:00:58Z

This PR is for improving the comments for previous PR #20312

Add new feature flag for lock screen widgets in Jetpack #20309 (✅ Approved)
Implement lock screen widgets UI #20312 (✅ Approved)
Add dynamic type support #20342 (TBD)
Add localizable string for "Views Today" title #20353 (✅ Approved) 👈 you're here!

Add localization key for "views today"

[BugFix] Fix widget of home screen for WordPress disappeared #20371 (✅ Approved)
Extract content logic to config from lock screen widget #20317 (✅ Approved)
Create a standalone TimeLineProvider and TimelineEntry for the lock screen #20368 (✅ Approved)
Implement view for logged-out, no-site, and no-data status #20399 (✅ Approved)
Notify to reload the timelines for lock screen widget #20405 (✅ Approved)
(Confirm the data display on UI correctly in this phase)
Implement event tracking for the new lock screen widget #20422 (✅ Approved)
Disable lockScreenWidget feature flag #20427 (In Reviewing)

Description

Add a new LocalizableStrings for "Views Today", because in some languages, we need better translation rather than simply concatenating two fields ("Views" + "Today").

Question: Based on the document, we use GlotPress for translation, should I need to manually add the key to notify translation team? (I don't have permission to access that)

Testing instructions

"Views Today" displayed on the bottom

Regression Notes

Potential unintended areas of impact
The UI representation for today views the widget in the lock screen
What I did to test those areas of impact (or what existing automated tests I relied on)
The widgets displayed as expected
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2023-03-17T08:05:50Z

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

staskus

Thanks for introducing a descriptive localized string!

I think we can clean up the View Model if fields are no longer needed. Otherwise, it looks good, thanks! 🚀

staskus · 2023-03-17T11:18:31Z

            title: title,
            value: getViews(),
            dateRange: dateRange,
+            footer: footer,


What do you think about naming it by purpose and not by location? I would say this is actually the title.

Oh yeah, you're right,
originally I was thinking of the name to separate from title and dateRange, so I choose footer 😅
but actually, as you said, we just need title for now.

staskus · 2023-03-17T11:18:56Z

        let viewModel = mapper.getLockScreenSingleStatViewModel(
            title: LocalizableStrings.viewsTitle,
-            dateRange: LocalizableStrings.todayWidgetTitle
+            dateRange: LocalizableStrings.todayWidgetTitle,


If we choose this direction, then we don't need dateRange.

Yes!! I forgot we don't need to toggle two layouts for now.
Let me update it for simplifying the code, thanks

staskus

👍 Looks good, thanks!

tzef · 2023-03-20T12:02:49Z

Hi @staskus
if there are no further concerns, could you please help to merge it,
so I can rebase the next PR #20317 for your review :)

staskus · 2023-03-20T12:49:38Z

@tzef

Merged!

tzef · 2023-03-20T13:49:37Z

@staskus

Merged!

Thank you very much. 🚀
I have already rebased the next PR #20317

* Add new feature flag for lock screen widgets in Jetpack (#20309) * Add new feature flag for widget in lock screen * Add new widget kind to widget configuration * Add empty lock screen widget * Add JETPACK_STATS_WIDGETS compilation condition To prevent lock screen widgets from displaying on WordPress target * Move LockScreenStatsWidgetsView to views folder group * Revert compilation condition, change to isJetpack of AppCondiguration * Implement lock screen widgets UI (#20312) * Extract statsUrl from private to extension for reusable with lock screen widget * Implement single stat view for today views widget Add view provider for handling building view for site selected status Add ViewModelMapper for converting viewModel from home widget data * Update LockScreenStatsWidgetsView body to get the view from view provider * Add mapper test to verify the viewModel converting from widget data correctly Add mapper and viewModel to WordPress target because app extension is not able to run unitTest * Fix getStatsURL typo * Add localizable string for "Views Today" title (#20353) * Add views in today localizable string for footer label * Remove dateRange and footer, only title is enough for existing feature * Fix home screen widget for WordPress target disappeared. (#20371) The root cause is the WidgetBundleBuilder body doesn't allow control flow statements, move it to supportedFamilies with feature flag to keep all control logic in the same place * Extract content logic to config from lock screen widget (#20317) * Update title of view provider from hardcoded to pass from config * Add lock screen stats widget config and implementation to include required information * Pass config to LockScreenStatsWidget Replaced the hardcoded data with config properties * Add associated type view for other status and TODO comments * Extract app configuration and feature flag check into config * Create a standalone TimeLineProvider and TimelineEntry for the lock screen (#20368) * Add widget data and timeline entry for lock screen to separate concerns * Add lock screen time line provider for lock screen stats widget entry Update stats widgets service result type to consist of home widget and lock screen widget for reusable * Update to use LockScreenSiteListProvider in LockScreenStatsWidget Update associated type widget data to conform `LockScreenStatsWidgetData` more Update model mapper and view provider to based on lock screen widget data Remove unnecessary `disabled` status from `LockScreenStatsWidgetsView` Remove unnecessary `widgetKind` parameter from `LockScreenStatsWidget` Remove unused statsURL converter from the view model mapper Add home widget data conform lock screen widget data extension to WordPress target for unitTest * Extract widget load data to loader for sharing with lock screen time line provider * Update widget reader to extract the cache read from getSnapshot * Extract noData, noSite, loggedOut, disabled status checking logic to data reader with status callback * Add unitTest for widget data reader Extract cache reading to `HomeWidgetDataFileReader` for mocking the testing object Extract app configuration is jetpack to parameter for mocking the config * Remove multiple space lines * Update multiple callback to Result and enum Error * Implement view for logged-out, no-site, and no-data status (#20399) * Add unconfigured view for lockscreen widget * Add unconfigured view model to view provider and model mapper * Add unconfigured view model unit test * Add background to unconfigured view align with success status widget appearance * Remove todo comments * Add reload timelines for lock screen widget (#20405) * Implement event tracking for the new lock screen widget (#20422) * Add event key to configuration and pass to trackers in lockscreen widget Expand tracks for lockscreen stats entry Add rectangular widgets count and widgets update of the new widget * Add lockscreen_widget source to deeplink tracked Update statsUrl to widgetUrl for separating the url from homescreen widgets * Update unitTests * Remove separate widget url, move widget source from widget data extension Add widget source type, assign the type in widgetURL in the view * Add widget url source test to verify the converting with DeepLinkSource * Disable the feature flag (#20427) --------- Co-authored-by: Beemo Lee <tzef8220@gmail.com>

Add views in today localizable string for footer label

f90be9f

tzef changed the title ~~Feature/beemotrial/lockscreen widgets localizable footer~~ Add localizable string for "Views Today" footer label Mar 17, 2023

tzef changed the base branch from trunk to feature/19411-add-lock-screen-stats-widgets March 17, 2023 01:02

tzef mentioned this pull request Mar 17, 2023

Add dynamic type support #20342

Closed

4 tasks

staskus self-requested a review March 17, 2023 06:43

staskus added Stats iOS 16 Widgets labels Mar 17, 2023

tzef mentioned this pull request Mar 17, 2023

Extract content logic to config from lock screen widget #20317

Merged

4 tasks

staskus reviewed Mar 17, 2023

View reviewed changes

Remove dateRange and footer, only title is enough for existing feature

3832691

tzef changed the title ~~Add localizable string for "Views Today" footer label~~ Add localizable string for "Views Today" title Mar 17, 2023

staskus approved these changes Mar 17, 2023

View reviewed changes

This was referenced Mar 20, 2023

Create a standalone TimeLineProvider and TimelineEntry for the lock screen #20368

Merged

Implement lock screen widgets UI #20312

Merged

Add new feature flag for lock screen widgets in Jetpack #20309

Merged

staskus merged commit 6b55e85 into wordpress-mobile:feature/19411-add-lock-screen-stats-widgets Mar 20, 2023

staskus mentioned this pull request Mar 30, 2023

iOS 16 Lock Screen Widgets: Today Views Widget #20435

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add localizable string for "Views Today" title - #20353

Add localizable string for "Views Today" title#20353
staskus merged 2 commits into
wordpress-mobile:feature/19411-add-lock-screen-stats-widgetsfrom
tzef:feature/beemotrial/lockscreen-widgets-localizable-footer

tzef commented Mar 17, 2023 •

edited

Loading

Uh oh!

peril-wordpress-mobile Bot commented Mar 17, 2023

Uh oh!

staskus left a comment

Uh oh!

staskus Mar 17, 2023

Uh oh!

tzef Mar 17, 2023 •

edited

Loading

Uh oh!

staskus Mar 17, 2023

Uh oh!

tzef Mar 17, 2023 •

edited

Loading

Uh oh!

staskus left a comment

Uh oh!

tzef commented Mar 20, 2023

Uh oh!

staskus commented Mar 20, 2023

Uh oh!

tzef commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tzef commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Regression Notes

Uh oh!

peril-wordpress-mobile Bot commented Mar 17, 2023

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

staskus Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

tzef Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staskus Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

tzef Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

tzef commented Mar 20, 2023

Uh oh!

staskus commented Mar 20, 2023

Uh oh!

tzef commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tzef commented Mar 17, 2023 •

edited

Loading

tzef Mar 17, 2023 •

edited

Loading

tzef Mar 17, 2023 •

edited

Loading