Skip to content

Implement view for logged-out, no-site, and no-data status - #20399

Merged
staskus merged 5 commits into
wordpress-mobile:feature/19411-add-lock-screen-stats-widgetsfrom
tzef:feature/beemotrial/lockscreen-widgets-unconfigure-ui
Mar 24, 2023
Merged

Implement view for logged-out, no-site, and no-data status#20399
staskus merged 5 commits into
wordpress-mobile:feature/19411-add-lock-screen-stats-widgetsfrom
tzef:feature/beemotrial/lockscreen-widgets-unconfigure-ui

Conversation

@tzef

@tzef tzef commented Mar 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is the PR for implementing the remaining status UI.

  1. Add new feature flag for lock screen widgets in Jetpack  #20309 (✅ Approved)
  2. Implement lock screen widgets UI #20312 (✅ Approved)
  3. Add dynamic type support #20342 (TBD)
  4. Add localizable string for "Views Today" title #20353 (✅ Approved)
  5. [BugFix] Fix widget of home screen for WordPress disappeared #20371 (✅ Approved)
  6. Extract content logic to config from lock screen widget #20317 (✅ Approved)
  7. Create a standalone TimeLineProvider and TimelineEntry for the lock screen  #20368 (✅ Approved)
  8. Implement view for logged-out, no-site, and no-data status #20399 (✅ Approved) 👈 you're here!
  9. Notify to reload the timelines for lock screen widget #20405 (✅ Approved)
    (Confirm the data display on UI correctly in this phase)
  10. Implement event tracking for the new lock screen widget  #20422 (✅ Approved)
  11. Disable lockScreenWidget feature flag #20427 (In Reviewing)

Description

Follow the existing unconfigured view style in the home screen widget to build the configured view for the lock screen widget.
Note: I set the fixed-size font to align with the success status widget.
image

Testing Instructions

You have to add the widget after the account switching due to the refresh notification not implemented yet (will be in next PR)

Logged Out

  1. Logged out
  2. Add today views widget to the lock screen
  3. Should see logged-out message in the widget

No Site

  1. Log in with a new account without any websites
  2. Add today views widget to the lock screen
  3. Should see no-site message in the widget

No Data

I don't know how to test it in normal steps without programmatically change the config

Regression Notes

  1. Potential unintended areas of impact
    N/A, no touch existing features

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    unconfigured view model mapping test in WidgetsViewModelMapperTests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@tzef
tzef marked this pull request as draft March 24, 2023 05:41
This was referenced Mar 24, 2023
Merged
Merged
Merged
Closed
Merged
Merged
@tzef
tzef force-pushed the feature/beemotrial/lockscreen-widgets-unconfigure-ui branch from fc6a2c2 to 4ccba33 Compare March 24, 2023 10:29
@tzef
tzef marked this pull request as ready for review March 24, 2023 10:31
@tzef

tzef commented Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @staskus , this is the next PR for review, thanks 🙏

@staskus
staskus self-requested a review March 24, 2023 10:46
staskus
staskus approved these changes Mar 24, 2023
View reviewed changes

@staskus staskus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzef it works as expected, and the code looks as expected. Thank you!

@staskus
staskus merged commit dd7a162 into wordpress-mobile:feature/19411-add-lock-screen-stats-widgets Mar 24, 2023
This was referenced Mar 27, 2023
Closed
Merged
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Mar 27, 2023

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

This was referenced Mar 28, 2023
Merged
Merged
Merged
@staskus staskus mentioned this pull request Mar 30, 2023
Merged
4 tasks
staskus added a commit that referenced this pull request Sep 4, 2023
@staskus @tzef
iOS 16 Lock Screen Widgets: Today Views Widget (#20435)
d45f864 
* Add new feature flag for lock screen widgets in Jetpack  (#20309)

* Add new feature flag for widget in lock screen

* Add new widget kind to widget configuration

* Add empty lock screen widget

* Add JETPACK_STATS_WIDGETS compilation condition

To prevent lock screen widgets from displaying on WordPress target

* Move LockScreenStatsWidgetsView to views folder group

* Revert compilation condition, change to isJetpack of AppCondiguration

* Implement lock screen widgets UI (#20312)

* Extract statsUrl from private to extension for reusable with lock screen widget

* Implement single stat view for today views widget

Add view provider for handling building view for site selected status
Add ViewModelMapper for converting viewModel from home widget data

* Update LockScreenStatsWidgetsView body to get the view from view provider

* Add mapper test to verify the viewModel converting from widget data correctly

Add mapper and viewModel to WordPress target because app extension is not able to run unitTest

* Fix getStatsURL typo

* Add localizable string for "Views Today" title (#20353)

* Add views in today localizable string for footer label

* Remove dateRange and footer, only title is enough for existing feature

* Fix home screen widget for WordPress target disappeared. (#20371)

The root cause is the WidgetBundleBuilder body doesn't allow control flow statements, move it to supportedFamilies with feature flag to keep all control logic in the same place

* Extract content logic to config from lock screen widget (#20317)

* Update title of view provider from hardcoded to pass from config

* Add lock screen stats widget config and implementation to include required information

* Pass config to LockScreenStatsWidget

Replaced the hardcoded data with config properties

* Add associated type view for other status and TODO comments

* Extract app configuration and feature flag check into config

* Create a standalone TimeLineProvider and TimelineEntry for the lock screen  (#20368)

* Add widget data and timeline entry for lock screen to separate concerns

* Add lock screen time line provider for lock screen stats widget entry

Update stats widgets service result type to consist of home widget and lock screen widget for reusable

* Update to use LockScreenSiteListProvider in LockScreenStatsWidget

Update associated type widget data to conform `LockScreenStatsWidgetData` more

Update model mapper and view provider to based on lock screen widget data

Remove unnecessary `disabled` status from `LockScreenStatsWidgetsView`

Remove unnecessary `widgetKind` parameter from `LockScreenStatsWidget`

Remove unused statsURL converter from the view model mapper

Add home widget data conform lock screen widget data extension to WordPress target for unitTest

* Extract widget load data to loader for sharing with lock screen time line provider

* Update widget reader to extract the cache read from getSnapshot

* Extract noData, noSite, loggedOut, disabled status checking logic to data reader with status callback

* Add unitTest for widget data reader

Extract cache reading to `HomeWidgetDataFileReader` for mocking the testing object

Extract app configuration is jetpack to parameter for mocking the config

* Remove multiple space lines

* Update multiple callback to Result and enum Error

* Implement view for logged-out, no-site, and no-data status (#20399)

* Add unconfigured view for lockscreen widget

* Add unconfigured view model to view provider and model mapper

* Add unconfigured view model unit test

* Add background to unconfigured view align with success status widget appearance

* Remove todo comments

* Add reload timelines for lock screen widget (#20405)

* Implement event tracking for the new lock screen widget  (#20422)

* Add event key to configuration and pass to trackers in lockscreen widget

Expand tracks for lockscreen stats entry

Add rectangular widgets count and widgets update of the new widget

* Add lockscreen_widget source to deeplink tracked

Update statsUrl to widgetUrl for separating the url from homescreen widgets

* Update unitTests

* Remove separate widget url, move widget source from widget data extension

Add widget source type, assign the type in widgetURL in the view

* Add widget url source test to verify the converting with DeepLinkSource

* Disable the feature flag (#20427)

---------

Co-authored-by: Beemo Lee <tzef8220@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

Assignees

No one assigned

Labels

Stats

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tzef @staskus