chore: hash more stuff for IPA.#15519
Merged
Merged
Conversation
added 5 commits
July 4, 2025 12:51
…lenge, and eval to hash_buffer for ipa.
…. hashing the commitment, challenge, and evaluation
…test WrongProofComponentFailure to pass
notnotraju
requested review from
IlyasRidhuan,
LeilaWang,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
notnotraju
commented
Jul 7, 2025
lucasxia01
reviewed
Jul 7, 2025
lucasxia01
left a comment
lucasxia01
left a comment
Contributor
There was a problem hiding this comment.
Nice, just requested some minor changes. Also why do you think this "argubly" solves the add_to_hash_buffer issue for the mock transcript?
| pol AVM_EXEC_OP_ID_RETURN = 512; | ||
| pol AVM_EXEC_OP_ID_REVERT = 1024; | ||
| pol AVM_EXEC_OP_ID_SUCCESSCOPY = 2048; | ||
| pol AVM_EXEC_OP_ID_RETURNDATASIZE = 4096; |
Contributor
There was a problem hiding this comment.
idk why this is changing in your PR
Contributor
Author
There was a problem hiding this comment.
This was the result of running yarn remake-constants, which I was prompted to do after fixing some of the other constants.
…ative ipa verifier, modified a couple of tests in goblin_recursive_verifier.test.cpp and client_ivc.test.cpp
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
42b65c1 to
8369b3f
Compare
ludamad
force-pushed
the
merge-train/barretenberg
branch
from
2abe998 to
3330e1c
Compare
ludamad
requested review from
LHerskind,
charlielye,
dbanks12,
just-mitch and
sirasistant
as code owners
ludamad
added
auto-rebase-pr
lucasxia01
reviewed
Jul 8, 2025
| tampered_proof.goblin_proof.merge_proof = civc_proof_2.goblin_proof.merge_proof; | ||
|
|
||
| EXPECT_FALSE(ClientIVC::verify(tampered_proof, civc_vk_1)); | ||
| EXPECT_DEATH(ClientIVC::verify(tampered_proof, civc_vk_1), ".*"); |
Contributor
There was a problem hiding this comment.
probably better to have something that's not just .*
Contributor
Author
There was a problem hiding this comment.
Yeah, I was debating this, but this ends up passing along the text for the error to the log (rather than constraining the error), which I thought was maybe better?
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). BEGIN_COMMIT_OVERRIDE chore: stdlib bool internal audit (#15070) feat: improve Shplonk api (#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (#15508) chore: nuke bit array (#15522) chore: remove template parameters (#15530) chore: no PK (#15386) chore!: Correct public inputs propagation in the tube (#15547) chore: use `batch_invert` in native IPA verifier (#15557) chore: Move `stdlib::uint_plookup` to `stdlib::uint` (#15460) chore: use const ref commitment keys (#15584) fix: hiding circuit vk computed only once (#15589) feat: transcript can hash objects independently (#15510) chore: readme for benchmarking remotely (#15512) chore: fix avm test (#15592) chore: hash more stuff for IPA. (#15519) chore: fix avm build in merge-train/bb (#15594) feat!: structured public inputs via kernel io (#15383) fix!: aggregate correct nested pairing points in the hiding circuit (#15598) fix: bb merge-train conflicts (#15617) chore: Refactor shplonk verifier api (#15618) chore!: databus consistency checks in the hiding circuit (#15599) feat!: VK hash consistency check (#15591) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com> Co-authored-by: notnotraju <raju@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com> Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <spalladino@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small
add_to_hash_buffermethod forMockTranscriptand then has the IPA prover add the commitment, challenge, and evaluation to the hash buffer.Addresses 1150 and at least part of 1408. See the commentary on the former for why this solution is the simplest/most ergonomic for soundness of IPA.