Skip to content

chore: Refactor shplonk verifier api#15618

Merged
federicobarbacovi merged 4 commits into
merge-train/barretenbergfrom
fb/refactor_shplonk_verifier_api
Jul 9, 2025
Merged

chore: Refactor shplonk verifier api#15618
federicobarbacovi merged 4 commits into
merge-train/barretenbergfrom
fb/refactor_shplonk_verifier_api

Conversation

@federicobarbacovi

@federicobarbacovi federicobarbacovi commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Refactor the Shplonk verifier api:

  • Remove OpeningVector (which was used only in Sphlonk) class in favour of ShplonkVerifier::UpdateData
  • Refactor methods using OpeningVector accordingly
  • Refactor ShplonkVerifier::update so that it uses a single opening pair (x, v) instead of a challenge x and a series of evaluations (v_1, .., v_k) (as it should be, given that the assertion of the verifier will only concern the v and not the single evaluations v_1, .., v_k).

@federicobarbacovi federicobarbacovi self-assigned this Jul 9, 2025
@federicobarbacovi federicobarbacovi marked this pull request as ready for review July 9, 2025 08:47
@federicobarbacovi federicobarbacovi marked this pull request as draft July 9, 2025 08:50
@federicobarbacovi federicobarbacovi marked this pull request as ready for review July 9, 2025 08:50
@federicobarbacovi federicobarbacovi enabled auto-merge (squash) July 9, 2025 10:00

@iakovenkos iakovenkos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@federicobarbacovi federicobarbacovi merged commit c627773 into merge-train/barretenberg Jul 9, 2025
4 checks passed
@federicobarbacovi federicobarbacovi deleted the fb/refactor_shplonk_verifier_api branch July 9, 2025 10:11
github-merge-queue Bot pushed a commit that referenced this pull request Jul 9, 2025
See
[merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).

BEGIN_COMMIT_OVERRIDE
chore: stdlib bool internal audit  (#15070)
feat: improve Shplonk api (#15422)
fix(merge-train): don't queue merge if merge-train failed queue, pass on
rebase logic (#15508)
chore: nuke bit array (#15522)
chore: remove template parameters (#15530)
chore: no PK (#15386)
chore!: Correct public inputs propagation in the tube (#15547)
chore: use `batch_invert` in native IPA verifier (#15557)
chore: Move `stdlib::uint_plookup` to `stdlib::uint` (#15460)
chore: use const ref commitment keys (#15584)
fix: hiding circuit vk computed only once (#15589)
feat: transcript can hash objects independently (#15510)
chore: readme for benchmarking remotely (#15512)
chore: fix avm test (#15592)
chore: hash more stuff for IPA. (#15519)
chore: fix avm build in merge-train/bb (#15594)
feat!: structured public inputs via kernel io (#15383)
fix!: aggregate correct nested pairing points in the hiding circuit
(#15598)
fix: bb merge-train conflicts (#15617)
chore: Refactor shplonk verifier api (#15618)
chore!: databus consistency checks in the hiding circuit (#15599)
feat!: VK hash consistency check (#15591)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com>
Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com>
Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com>
Co-authored-by: notnotraju <raju@aztec-labs.com>
Co-authored-by: Lucas Xia <lucasxia01@gmail.com>
Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com>
Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com>
Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
Co-authored-by: Santiago Palladino <spalladino@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants