fix: hiding circuit vk computed only once#15589
Merged
Merged
Conversation
iakovenkos
commented
Jul 8, 2025
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1431): Avoid computing the hiding circuit verification | ||
| // key during proving. Precompute instead. | ||
| auto hiding_circuit_vk = std::make_shared<MegaZKVerificationKey>(hiding_decider_pk->get_precomputed()); | ||
| auto& hiding_circuit_vk = honk_vk; |
Contributor
Author
There was a problem hiding this comment.
honk_vk is computed in construct_hiding_circuit_key, which is precisely the hiding circuit vk
Contributor
There was a problem hiding this comment.
good catch. I really dont like how this code is arranged anyway but seems slightly more clear to me to continue to compute it here and remove it from construct_hiding_circuit_key - unless there's some compelling reason I'm missing
Contributor
There was a problem hiding this comment.
We use the honk_vk constructed from construct_hiding_circuit_key in other places, like when we call write_vk.
ledwards2225
approved these changes
Jul 8, 2025
ledwards2225
left a comment
ledwards2225
left a comment
Contributor
There was a problem hiding this comment.
LG - one suggestion
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1431): Avoid computing the hiding circuit verification | ||
| // key during proving. Precompute instead. | ||
| auto hiding_circuit_vk = std::make_shared<MegaZKVerificationKey>(hiding_decider_pk->get_precomputed()); | ||
| auto& hiding_circuit_vk = honk_vk; |
Contributor
There was a problem hiding this comment.
good catch. I really dont like how this code is arranged anyway but seems slightly more clear to me to continue to compute it here and remove it from construct_hiding_circuit_key - unless there's some compelling reason I'm missing
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). BEGIN_COMMIT_OVERRIDE chore: stdlib bool internal audit (#15070) feat: improve Shplonk api (#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (#15508) chore: nuke bit array (#15522) chore: remove template parameters (#15530) chore: no PK (#15386) chore!: Correct public inputs propagation in the tube (#15547) chore: use `batch_invert` in native IPA verifier (#15557) chore: Move `stdlib::uint_plookup` to `stdlib::uint` (#15460) chore: use const ref commitment keys (#15584) fix: hiding circuit vk computed only once (#15589) feat: transcript can hash objects independently (#15510) chore: readme for benchmarking remotely (#15512) chore: fix avm test (#15592) chore: hash more stuff for IPA. (#15519) chore: fix avm build in merge-train/bb (#15594) feat!: structured public inputs via kernel io (#15383) fix!: aggregate correct nested pairing points in the hiding circuit (#15598) fix: bb merge-train conflicts (#15617) chore: Refactor shplonk verifier api (#15618) chore!: databus consistency checks in the hiding circuit (#15599) feat!: VK hash consistency check (#15591) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com> Co-authored-by: notnotraju <raju@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com> Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <spalladino@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.