Do not crash on timeline hover/selection when a profile doesn't have any samples or markers#5086
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5086 +/- ##
==========================================
- Coverage 88.49% 88.49% -0.01%
==========================================
Files 304 304
Lines 27463 27470 +7
Branches 7430 7433 +3
==========================================
+ Hits 24303 24309 +6
- Misses 2935 2936 +1
Partials 225 225 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Aug 20, 2024
canova
force-pushed
the
fix-empty-timeline
branch
2 times, most recently
from
0abf794 to
6901b41
Compare
canova
force-pushed
the
fix-empty-timeline
branch
from
6901b41 to
a0e7e20
Compare
Merged
canova
added a commit
that referenced
this pull request
Sep 5, 2024
[Tatsuyuki Ish] Fix type error in getPagesMap (#5063) [Nazım Can Altınova] [Tab selector 1] Add a redux state for the tab filter (#5072) [Markus Stange] Remove a test for the inverted stack chart. (#5075) [Markus Stange] Add an inverted tree test for getSamplesSelectedStates and getTreeOrderComparator (#5076) [Nazım Can Altınova] [Tab selector 2] Extract the page data in the full view (#5073) [Nazım Can Altınova] Do not crash on timeline hover/selection when a profile doesn't have any samples or markers (#5086) [Nazım Can Altınova] [Tab selector 3] Generate page information for all tabs (#5082) [Nazım Can Altınova] [Tab selector 4] Add a getTabToThreadIndexesMap selector to get relevant threads per tab (#5087) [joshuaobrien] Use the word 'archive' instead of 'zip file' in copy (#5081) [Markus Stange] Send a UserAgent header to the symbolication server again (#5103) [Julien Wajsberg] Add some console utilities to retrieve the current profile and save it to disk (#5105) [Nazım Can Altınova] Add `selectedMarker` to the console APIs (#5107) And various dependency updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5037.
It was happening because we were trying to find the timestamp of the hovered mouse location. Also I noticed that the same thing happens when we try to select a time range in an empty timeline. This should fix both of the issues.
Right before I was publishing this PR, I also noticed that when you upload an empty profile the home page also crashes because it tries to calculate the range too in the published profiles list. So I fixed that one as well.
Deploy preview / Production