Add some console utilities to retrieve the current profile and save it to disk#5105
Merged
julienw merged 6 commits intoAug 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
==========================================
- Coverage 88.48% 88.42% -0.07%
==========================================
Files 304 304
Lines 27523 27549 +26
Branches 7444 7450 +6
==========================================
+ Hits 24355 24360 +5
- Misses 2943 2961 +18
- Partials 225 228 +3 ☔ View full report in Codecov by Sentry. |
canova
approved these changes
Aug 30, 2024
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks good to me with the content type fixed, thanks!
| }; | ||
|
|
||
| target.saveToDisk = async function ( | ||
| rawGeckoProfile: MixedObject | ArrayBuffer, |
Member
There was a problem hiding this comment.
I guess this could any object as well like you said in Matrix and not only rawGeckoProfile. Maybe rename this to reflect that?
| : JSON.stringify(rawGeckoProfile); | ||
|
|
||
| const blob = new Blob([arrayBuffer], { | ||
| type: 'application/octet-strea', |
Member
There was a problem hiding this comment.
Suggested change
| type: 'application/octet-strea', | |
| type: 'application/octet-stream', |
julienw
force-pushed
the
add-console-to-retrieve-profile
branch
from
3c7ad63 to
1a3b9da
Compare
canova
approved these changes
Aug 30, 2024
…rConnectionStatus item
julienw
force-pushed
the
add-console-to-retrieve-profile
branch
from
1a3b9da to
6a01689
Compare
This was referenced Sep 3, 2024
Merged
canova
added a commit
that referenced
this pull request
Sep 5, 2024
[Tatsuyuki Ish] Fix type error in getPagesMap (#5063) [Nazım Can Altınova] [Tab selector 1] Add a redux state for the tab filter (#5072) [Markus Stange] Remove a test for the inverted stack chart. (#5075) [Markus Stange] Add an inverted tree test for getSamplesSelectedStates and getTreeOrderComparator (#5076) [Nazım Can Altınova] [Tab selector 2] Extract the page data in the full view (#5073) [Nazım Can Altınova] Do not crash on timeline hover/selection when a profile doesn't have any samples or markers (#5086) [Nazım Can Altınova] [Tab selector 3] Generate page information for all tabs (#5082) [Nazım Can Altınova] [Tab selector 4] Add a getTabToThreadIndexesMap selector to get relevant threads per tab (#5087) [joshuaobrien] Use the word 'archive' instead of 'zip file' in copy (#5081) [Markus Stange] Send a UserAgent header to the symbolication server again (#5103) [Julien Wajsberg] Add some console utilities to retrieve the current profile and save it to disk (#5105) [Nazım Can Altınova] Add `selectedMarker` to the console APIs (#5107) And various dependency updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.