[TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs#16254
Conversation
6366ab6 to
dd396bd
Compare
0a29694 to
1f5d7ee
Compare
📝 WalkthroughWalkthroughThe configuration database adds workload profiles and validated TensorRT-LLM provenance. Recipe validation, database generation, B200 configurations, published JSON/YAML data, the configuration selector, and related tests are updated to propagate and display these fields. ChangesProfile-aware configuration database
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ProfileSelect
participant ConfigSelector
participant ConfigDatabase
ProfileSelect->>ConfigSelector: Select profile
ConfigSelector->>ConfigDatabase: Filter entries by profile
ConfigDatabase-->>ConfigSelector: Return compatible entries
ConfigSelector-->>ProfileSelect: Render resolved configuration and validation metadata
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml (1)
1-20: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the required NVIDIA copyright headers to the new recipe files.
examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml#L1-L20: Add the SPDX copyright comment beforemax_batch_size.examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc256.yaml#L1-L25: Add the SPDX copyright comment beforemax_batch_size.examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc4.yaml#L1-L20: Add the SPDX copyright comment beforemax_batch_size.examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc8.yaml#L1-L20: Add the SPDX copyright comment beforemax_batch_size.As per coding guidelines, “Add the NVIDIA copyright header to all new files.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml` around lines 1 - 20, Prepend the standard NVIDIA SPDX copyright header before max_batch_size in all four new recipe files: examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml lines 1-20, 8k1k_tp4_conc256.yaml lines 1-25, 8k1k_tp4_conc4.yaml lines 1-20, and 8k1k_tp4_conc8.yaml lines 1-20. Leave the existing YAML configuration unchanged.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc16.yaml`:
- Line 1: Add the repository-standard NVIDIA copyright header before the first
configuration key in all four files:
examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc16.yaml:1-1,
1k1k_tp4_conc256.yaml:1-1, 1k1k_tp4_conc4.yaml:1-1, and 1k1k_tp4_conc8.yaml:1-1.
Preserve each file’s existing configuration content, including cuda_graph_config
or max_batch_size.
---
Outside diff comments:
In
`@examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml`:
- Around line 1-20: Prepend the standard NVIDIA SPDX copyright header before
max_batch_size in all four new recipe files:
examples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yaml
lines 1-20, 8k1k_tp4_conc256.yaml lines 1-25, 8k1k_tp4_conc4.yaml lines 1-20,
and 8k1k_tp4_conc8.yaml lines 1-20. Leave the existing YAML configuration
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6a856656-f88c-49e6-8dfc-052caf5e0c8b
📒 Files selected for processing (26)
docs/source/_static/config_db.jsondocs/source/_static/config_selector.cssdocs/source/_static/config_selector.jsexamples/configs/database/database.pyexamples/configs/database/lookup.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc16.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc256.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc4.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp4_conc8.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp8_conc128.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp8_conc256.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp8_conc32.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp8_conc4.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/1k1k_tp8_conc64.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc16.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc256.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc4.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp4_conc8.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp8_conc128.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp8_conc256.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp8_conc4.yamlexamples/configs/database/nvidia/DeepSeek-R1-0528-FP4-v2/B200/8k1k_tp8_conc64.yamlscripts/generate_config_database_tests.pyscripts/generate_config_table.pytests/unittest/tools/test_config_database_sync.pytests/unittest/tools/test_config_selector.js
1f5d7ee to
cb49bb4
Compare
|
/bot run |
|
PR_Github #60484 [ run ] triggered by Bot. Commit: |
|
PR_Github #60484 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #60522 [ run ] triggered by Bot. Commit: |
BowenFu
left a comment
There was a problem hiding this comment.
LGTM — purely additive tooling: all changes are under docs/static, examples/configs/database (new recipe YAMLs + provenance), scripts/generate_config*, and tests; no tensorrt_llm/ runtime source is touched, so users not using IBDB recipes see zero behavior change. (Worth addressing CodeRabbit's ask for NVIDIA copyright headers on the new YAML recipe files.)
|
PR_Github #60522 [ run ] completed with state
|
cb49bb4 to
61f21e0
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #60722 [ run ] triggered by Bot. Commit: |
|
PR_Github #60722 [ run ] completed with state
|
|
/bot run |
|
PR_Github #60808 [ run ] triggered by Bot. Commit: |
|
PR_Github #60808 [ run ] completed with state
|
|
/bot run |
|
PR_Github #60842 [ run ] triggered by Bot. Commit: |
|
PR_Github #60842 [ run ] completed with state
|
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
61f21e0 to
e355249
Compare
|
/bot run |
|
PR_Github #60882 [ run ] triggered by Bot. Commit: |
|
PR_Github #60882 [ run ] completed with state
|
|
/bot run |
|
PR_Github #61018 [ run ] triggered by Bot. Commit: |
|
PR_Github #61018 [ run ] completed with state |
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce * 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits) [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159) [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798) [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732) [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420) [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524) [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422) [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348) [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410) [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786) [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433) [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781) [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777) [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017) [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704) [None][chore] Remove attention backend test waivers (NVIDIA#16723) [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703) [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254) [None][infra] Preview/bump/main (NVIDIA#16758) ... Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
…VIDIA#16254) Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Description
Add the public config-database support needed for IBDB-sourced recipe refreshes and include the first DeepSeek/B200 batch.
This change:
validated_trtllm_versionandvalidated_trtllm_commitprovenance metadata;profilediscriminator for latency and throughput variants, with an optional balanced variant;nvidia/DeepSeek-R1-0528-FP4-v2B200 recipes from IBDB Pareto records validated against TensorRT-LLMv1.3.0rc14at commit93cb6518b6d6dbd6095748189e626db731f44545;config_db.json.IBDB record, study, and job identifiers remain private and are not written to this repository. Existing recipes remain valid without provenance metadata. There are no new dependencies or protected TensorRT-LLM API changes.
Related ticket: TRTLLM-13694.
Test Coverage
python scripts/generate_config_table.py— passed.python tests/unittest/tools/test_config_database_sync.py TestConfigDatabaseSync.test_config_db_json_generation TestConfigDatabaseSync.test_profile_and_validated_commit_metadata TestConfigDatabaseSync.test_recipe_metadata_validation— 3 passed.node --test tests/unittest/tools/test_config_selector.js— passed.tests/unittest/llmapi/test_config_database.pywas not run locally because the checkout lacks its TensorRT-LLM runtime dependencies; it remains required in CI.Summary by CodeRabbit