Skip to content

sync: prepare upstream dependency and runtime foundations#108

Merged
aaditagrawal merged 1 commit into
mainfrom
sync/foundation-client-runtime
Jun 24, 2026
Merged

sync: prepare upstream dependency and runtime foundations#108
aaditagrawal merged 1 commit into
mainfrom
sync/foundation-client-runtime

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jun 24, 2026

Copy link
Copy Markdown
Owner

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Summary by CodeRabbit

  • New Features

    • Expanded platform support across desktop, web, mobile, and server apps.
    • Added broader account/authentication and passkey support.
    • Improved availability of developer/runtime features used by the app.
  • Bug Fixes

    • Fixed Electron binary loading so packaged desktop builds can locate required files more reliably.
    • Improved session handling for HTTP-based workflows.
  • Tests

    • Added coverage for provider contract decoding and runtime event handling.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 876840cd-6113-4721-99e9-be820fab17bb

📥 Commits

Reviewing files that changed from the base of the PR and between 9d141c1 and 21ff7cc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (35)
  • apps/desktop/package.json
  • apps/mobile/package.json
  • apps/server/package.json
  • apps/web/package.json
  • packages/client-runtime/package.json
  • packages/client-runtime/src/authorization/index.ts
  • packages/client-runtime/src/connection/index.ts
  • packages/client-runtime/src/environment/index.ts
  • packages/client-runtime/src/errors/index.ts
  • packages/client-runtime/src/operations/index.ts
  • packages/client-runtime/src/operations/projects.ts
  • packages/client-runtime/src/platform/index.ts
  • packages/client-runtime/src/relay/index.ts
  • packages/client-runtime/src/rpc/index.ts
  • packages/client-runtime/src/state/archivedThreads.ts
  • packages/client-runtime/src/state/checkpointDiff.ts
  • packages/client-runtime/src/state/composerPathSearch.ts
  • packages/client-runtime/src/state/filesystem.ts
  • packages/client-runtime/src/state/git.ts
  • packages/client-runtime/src/state/models.ts
  • packages/client-runtime/src/state/projects.ts
  • packages/client-runtime/src/state/relayDiscovery.ts
  • packages/client-runtime/src/state/runtime.ts
  • packages/client-runtime/src/state/shell.ts
  • packages/client-runtime/src/state/sourceControl.ts
  • packages/client-runtime/src/state/terminal.ts
  • packages/client-runtime/src/state/threads.ts
  • packages/client-runtime/src/state/vcs.ts
  • packages/contracts/src/provider.test.ts
  • packages/contracts/src/providerRuntime.test.ts
  • patches/@ff-labs__fff-node@0.9.4.patch
  • patches/@pierre%2Fdiffs@1.1.20.patch
  • patches/@pierre%2Fdiffs@1.3.0-beta.5.patch
  • patches/effect@4.0.0-beta.78.patch
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The PR pins @clerk/* packages to snapshot versions and bumps @pierre/diffs to 1.3.0-beta.5 in the workspace catalog, applies three patches (asar-unpacked binary resolution for fff-node, editor option simplification for pierre/diffs, and an MCP session DELETE endpoint for effect), adds Electron/Expo/shiki dependencies across app package.json files, expands client-runtime's public export surface with new subpath entries and barrel index files, and adds provider contract tests.

Changes

Dependency Management, client-runtime API Surface, and Contract Tests

Layer / File(s) Summary
Workspace catalog, overrides, and patched dependencies
pnpm-workspace.yaml
Pins @clerk/* packages to snapshot versions, bumps @pierre/diffs to 1.3.0-beta.5, adds @clerk/* catalog: overrides, constrains @pierre/diffs>@shikijs/transformers`` to ^4.2.0, and registers patches for `@ff-labs/fff-node@0.9.4` and `@pierre/diffs@1.3.0-beta.5`.
Patches: fff-node asar resolution, pierre/diffs editor options, effect MCP DELETE
patches/@ff-labs__fff-node@0.9.4.patch, patches/@pierre%2Fdiffs@1.3.0-beta.5.patch, patches/effect@4.0.0-beta.78.patch
fff-node patch adds resolveUnpackedAsarPath to prefer app.asar.unpacked binaries. pierre/diffs patch simplifies Editor.edit() defaults, adds an early-return in the gutter pointerdown handler for line-selection mode, strips gutter/selection overrides from mergeFileOptions(), and extends the package exports map. effect patch adds a conditional HTTP DELETE handler to McpServer that validates the session-id header and removes the session from clientSessions.
App-level package.json dependency additions
apps/desktop/package.json, apps/mobile/package.json, apps/server/package.json, apps/web/package.json
desktop adds @clerk/electron, @clerk/electron-passkeys, electron-store, playwright-core, react-grab, and tailwindcss. mobile migrates @clerk/expo to catalog:, bumps @shikijs/* to 4.2.0, adds expo-asset, expo-network, and @pierre/trees. server adds @ff-labs/fff-node@0.9.4. web migrates Clerk deps to catalog:, adds @clerk/electron and @pierre/trees.
client-runtime subpath exports and barrel index files
packages/client-runtime/package.json, packages/client-runtime/src/authorization/index.ts, packages/client-runtime/src/connection/index.ts, packages/client-runtime/src/environment/index.ts, packages/client-runtime/src/errors/index.ts, packages/client-runtime/src/operations/..., packages/client-runtime/src/platform/index.ts, packages/client-runtime/src/relay/index.ts, packages/client-runtime/src/rpc/index.ts, packages/client-runtime/src/state/*
package.json adds explicit subpath exports for ./connection, ./authorization, ./environment, ./errors, ./rpc, ./operations, ./platform, ./relay, and multiple ./state/* paths. Each corresponding barrel index file is populated with export * re-exports pointing to the underlying implementation modules.
Provider contract tests
packages/contracts/src/provider.test.ts, packages/contracts/src/providerRuntime.test.ts
Adds decoders and test assertions for ProviderListModelsInput (slug cursor) and ProviderGetUsageInput (slug codex). Adds a RuntimeEventRaw decoder and a test iterating over fork provider source identifiers verifying round-trip decoding.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 Hop, hop, the exports grow wide,
New barrel files line every guide.
Clerk snapshots pinned, the diffs patched neat,
Asar paths found — the binaries complete!
With provider tests checking slug by slug,
This rabbit ships a tidy shrug. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/foundation-client-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Jun 24, 2026
@github-actions github-actions Bot added the size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). label Jun 24, 2026
@aaditagrawal
aaditagrawal marked this pull request as ready for review June 24, 2026 08:43
@aaditagrawal
aaditagrawal merged commit 05d624f into main Jun 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant