Skip to content

Add file preview comments and task toggles (#3115)#114

Merged
aaditagrawal merged 14 commits into
mainfrom
sync/upstream-20260617-inline-panel-comments
Jun 24, 2026
Merged

Add file preview comments and task toggles (#3115)#114
aaditagrawal merged 14 commits into
mainfrom
sync/upstream-20260617-inline-panel-comments

Conversation

@aaditagrawal

Copy link
Copy Markdown
Owner

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3085de1e-f75f-4c1c-a087-22cbe7ce02b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/upstream-20260617-inline-panel-comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

aaditagrawal added 3 commits June 24, 2026 13:55
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
@aaditagrawal
aaditagrawal marked this pull request as ready for review June 24, 2026 08:45
@aaditagrawal
aaditagrawal changed the base branch from sync/upstream-20260616-right-panel-search-relay to main June 24, 2026 08:52
@aaditagrawal
aaditagrawal merged commit d6a9c69 into main Jun 24, 2026
26 of 28 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe6cb520a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3883 to +3886
const messageTextForSend = appendReviewCommentsToPrompt(
messageTextWithPreviewAnnotations,
composerReviewCommentsSnapshot,
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Parse review comments before trailing context blocks

When a send includes a review comment together with a preview annotation, terminal context, or element context, this appends the <review_comment> after the existing context blocks. UserTimelineRow still extracts preview annotations and terminal/element contexts only from the trailing end before UserMessageBody parses review comments, so those blocks no longer match and the transcript loses the preview/terminal/element cards or leaks their raw text. Strip review comments before those trailing extractors or update the display pipeline to handle this ordering.

Useful? React with 👍 / 👎.

Comment on lines +142 to +145
for (const annotation of remapped) {
for (const entry of annotation.metadata.entries) {
if (entry.kind !== "comment") continue;
addReviewComment(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not resurrect removed file comments

When a file preview comment is removed from the composer pill while this file editor stays mounted, the local lineAnnotations entry is never removed. On the next edit/remap, Pierre supplies that stale annotation in nextLineAnnotations, and this loop calls addReviewComment again, so the deleted comment reappears and can still be sent. Sync lineAnnotations with composer removals or filter remaps against the current draft comments before re-adding.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants