Add file preview comments and task toggles (#3115)#114
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
…ync/upstream-20260617-inline-panel-comments
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe6cb520a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const messageTextForSend = appendReviewCommentsToPrompt( | ||
| messageTextWithPreviewAnnotations, | ||
| composerReviewCommentsSnapshot, | ||
| ); |
There was a problem hiding this comment.
Parse review comments before trailing context blocks
When a send includes a review comment together with a preview annotation, terminal context, or element context, this appends the <review_comment> after the existing context blocks. UserTimelineRow still extracts preview annotations and terminal/element contexts only from the trailing end before UserMessageBody parses review comments, so those blocks no longer match and the transcript loses the preview/terminal/element cards or leaks their raw text. Strip review comments before those trailing extractors or update the display pipeline to handle this ordering.
Useful? React with 👍 / 👎.
| for (const annotation of remapped) { | ||
| for (const entry of annotation.metadata.entries) { | ||
| if (entry.kind !== "comment") continue; | ||
| addReviewComment( |
There was a problem hiding this comment.
Do not resurrect removed file comments
When a file preview comment is removed from the composer pill while this file editor stays mounted, the local lineAnnotations entry is never removed. On the next edit/remap, Pierre supplies that stale annotation in nextLineAnnotations, and this loop calls addReviewComment again, so the deleted comment reappears and can still be sent. Sync lineAnnotations with composer removals or filter remaps against the current draft comments before re-adding.
Useful? React with 👍 / 👎.

What Changed
Why
UI Changes
Checklist