chore: remove AnnotatableFileDiff leftovers, rename file (#3488) - #123
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
pingdotgg#3480) Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Julius Marminge <julius@mac.lan> Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Codex <codex@openai.com> Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
…pstream-20260622-final-ui-runtime
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd85a5ccc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| proof, | ||
| method: input.request.method, | ||
| url: requestAbsoluteUrl(input.request), | ||
| url: url.value.href, |
There was a problem hiding this comment.
Preserve the original request URL for DPoP verification
When DPoP-protected requests are served from a Web Request or behind a proxy that sends a combined x-forwarded-proto value such as https,http, HttpServerRequest.toURL() rebuilds the URL from request.url/headers instead of using request.originalUrl and only treats the proto as HTTPS on an exact "https" match. That can pass http://localhost/... or http://host/... into verifyDpopProof, while the client signed the public HTTPS URL in htu, so otherwise valid mobile/relay auth requests are rejected with a URL mismatch. Keep the previous original-URL/first-forwarded-value reconstruction for this verifier.
Useful? React with 👍 / 👎.
| }) { | ||
| const [copied, setCopied] = useState(false); | ||
| const [wrapped, setWrapped] = useState(false); | ||
| const [wrapped, setWrapped] = useState(readInitialWordWrapSetting); |
There was a problem hiding this comment.
Subscribe markdown wrapping to hydrated settings
When a user has saved wordWrap: false and reloads directly into a chat, the client-settings snapshot is still the default (true) until hydrateClientSettings() completes. Because this useState initializer reads that snapshot once and ChatMarkdown does not subscribe to useClientSettings, already-rendered code blocks remain wrapped until they are remounted or manually toggled, so the persisted preference is ignored on initial chat render. Consider using the settings hook (or waiting for hydration) for the initial wrap state.
Useful? React with 👍 / 👎.

What Changed
Why
UI Changes
Checklist