Skip to content

chore: remove AnnotatableFileDiff leftovers, rename file (#3488) - #123

Merged
aaditagrawal merged 31 commits into
mainfrom
sync/upstream-20260622-final-ui-runtime
Jun 24, 2026
Merged

chore: remove AnnotatableFileDiff leftovers, rename file (#3488)#123
aaditagrawal merged 31 commits into
mainfrom
sync/upstream-20260622-final-ui-runtime

Conversation

@aaditagrawal

Copy link
Copy Markdown
Owner

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

ipanasenko and others added 17 commits June 21, 2026 20:31
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3a5d755-dceb-4a91-b3e5-b967ed5b2dde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/upstream-20260622-final-ui-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 24, 2026
aaditagrawal added 14 commits June 24, 2026 12:12
@aaditagrawal
aaditagrawal marked this pull request as ready for review June 24, 2026 08:45
@aaditagrawal
aaditagrawal changed the base branch from sync/upstream-20260621-runtime-diagnostics to main June 24, 2026 08:54
@aaditagrawal
aaditagrawal merged commit d7b8d8e into main Jun 24, 2026
26 of 28 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd85a5ccc4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

proof,
method: input.request.method,
url: requestAbsoluteUrl(input.request),
url: url.value.href,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the original request URL for DPoP verification

When DPoP-protected requests are served from a Web Request or behind a proxy that sends a combined x-forwarded-proto value such as https,http, HttpServerRequest.toURL() rebuilds the URL from request.url/headers instead of using request.originalUrl and only treats the proto as HTTPS on an exact "https" match. That can pass http://localhost/... or http://host/... into verifyDpopProof, while the client signed the public HTTPS URL in htu, so otherwise valid mobile/relay auth requests are rejected with a URL mismatch. Keep the previous original-URL/first-forwarded-value reconstruction for this verifier.

Useful? React with 👍 / 👎.

}) {
const [copied, setCopied] = useState(false);
const [wrapped, setWrapped] = useState(false);
const [wrapped, setWrapped] = useState(readInitialWordWrapSetting);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Subscribe markdown wrapping to hydrated settings

When a user has saved wordWrap: false and reloads directly into a chat, the client-settings snapshot is still the default (true) until hydrateClientSettings() completes. Because this useState initializer reads that snapshot once and ChatMarkdown does not subscribe to useClientSettings, already-rendered code blocks remain wrapped until they are remounted or manually toggled, so the persisted preference is ignored on initial chat render. Consider using the settings hook (or waiting for hydration) for the initial wrap state.

Useful? React with 👍 / 👎.

@aaditagrawal
aaditagrawal deleted the sync/upstream-20260622-final-ui-runtime branch August 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants