Skip to content

Unify compact subheaders and diff file navigation - #113

Merged
aaditagrawal merged 26 commits into
mainfrom
sync/upstream-20260616-right-panel-search-relay
Jun 24, 2026
Merged

Unify compact subheaders and diff file navigation#113
aaditagrawal merged 26 commits into
mainfrom
sync/upstream-20260616-right-panel-search-relay

Conversation

@aaditagrawal

Copy link
Copy Markdown
Owner

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

juliusmarminge and others added 14 commits June 15, 2026 15:58
- Add shared compact subheader styling for preview, file, and diff panels
- Open diff files in the thread file viewer when available
- Fix macOS cursor auto-hide and Option-modified shortcut matching
- Align header controls with the 12px right inset
- Use a smaller control offset in window controls overlay mode
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
…g#2421)

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 511cd5f2-1b62-4a67-95eb-745ba676ed97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/upstream-20260616-right-panel-search-relay

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). label Jun 24, 2026
@aaditagrawal
aaditagrawal marked this pull request as ready for review June 24, 2026 08:45
@aaditagrawal
aaditagrawal changed the base branch from sync/upstream-20260615-file-browser to main June 24, 2026 08:48
@aaditagrawal
aaditagrawal merged commit 243e2da into main Jun 24, 2026
17 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a38a422097

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1 to +5
{
"platforms": ["apple"],
"apple": {
"modules": ["T3ComposerEditorModule"]
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add package metadata for the composer module

This new local Expo module is consumed by the iOS composer via requireNativeView("T3ComposerEditor"), but the module directory only adds expo-module.config.json/podspec files and no package.json metadata. Expo autolinking expects the module config to live next to a package manifest, so iOS prebuild will not discover/register T3ComposerEditorModule; mounting the composer will then fail with a missing native view. Add the local module package metadata (and app dependency/podspec path as needed) so it is autolinked.

Useful? React with 👍 / 👎.

Comment on lines +170 to +172
expect(workflow).toContain('--github-env-file "$RUNNER_TEMP/relay-client-tracing.env"');
expect(workflow).toContain("name: relay-client-tracing-config");
expect(workflow).toContain('cat "$config_path" >> "$GITHUB_ENV"');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Commit the release workflow changes these assertions require

These new assertions currently fail because .github/workflows/release.yml in this commit does not contain --github-env-file, relay-client-tracing-config, or the cat "$config_path" >> "$GITHUB_ENV" step (a repo-wide rg only finds those strings in this test/deploy script). As a result the infra relay test suite will fail until the corresponding workflow update is included or the test is adjusted.

Useful? React with 👍 / 👎.

#import <react/renderer/components/T3MarkdownTextSpec/Props.h>
#import <react/renderer/components/T3MarkdownTextSpec/RCTComponentViewHelpers.h>
#import "RCTFabricComponentsPlugins.h"
#import "Utils.h"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove missing Utils.h imports

This source file is included by T3MarkdownText.podspec's ios/**/*.{h,m,mm,cpp} glob, but it imports Utils.h; a repo-wide find . -name Utils.h has no match (the same missing include also appears in T3MarkdownTextManager.mm). Once the markdown module builds for iOS, the pod target will fail to compile with a missing-header error unless this unused/generated include is removed or the header is added.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants