fix(web): Remove saved environments atomically (#2917) by aaditagrawal · Pull Request #117 · aaditagrawal/t3code

aaditagrawal · 2026-06-24T05:43:17Z

What Changed

Why

UI Changes

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Co-authored-by: Julius Marminge <julius@mac.lan> Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Julius Marminge <jmarminge@gmail.com>

Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com>

…dotgg#3103) Co-authored-by: codex <codex@users.noreply.github.com>

…3065) Co-authored-by: codex <codex@users.noreply.github.com>

…gg#3073) Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com> Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: Julius Marminge <julius@mac.lan>

Co-authored-by: codex <codex@users.noreply.github.com>

…3172)

aaditagrawal · 2026-06-24T05:43:31Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2026-06-24T05:43:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4018a4a1-502a-409c-9d3f-8fdfbd4ef362

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch sync/upstream-20260619-post-connection-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…nc/upstream-20260619-post-connection-runtime

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55f8bd37e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-24T09:17:00Z

+            Electron.protocol.handle(input.scheme, (request) =>
+              proxyRequest(request, input.targetOrigin, contentSecurityPolicy),


Register desktop schemes before handling them

When the renderer is loaded from t3code://app, this handler is installed without the previous pre-ready registerSchemesAsPrivileged call. Electron treats unprivileged custom schemes as non-standard, which disables web storage and makes resource resolution unreliable; under the new custom-origin desktop renderer this can break localStorage/IndexedDB-backed state and asset loading. Register t3code/t3code-dev as standard/secure before app.ready before calling protocol.handle.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-24T09:17:00Z

          APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
+          APPLE_TEAM_ID: ${{ vars.APPLE_TEAM_ID }}
+          MACOS_PROVISIONING_PROFILE: ${{ secrets.MACOS_PROVISIONING_PROFILE }}
+          T3CODE_CLERK_PASSKEY_RP_DOMAINS: ${{ vars.CLERK_PASSKEY_RP_DOMAINS }}


Forward the Clerk key for signed macOS releases

The signed macOS build now calls resolveMacPasskeySigningConfiguration; if the optional CLERK_PASSKEY_RP_DOMAINS repo variable is unset, that code falls back to T3CODE_CLERK_PUBLISHABLE_KEY, but this workflow does not export that key and CI has no checked-in .env. A fully configured signing run will therefore fail with the “publishable key or RP domains is required” error unless the supposedly optional RP-domain variable is also configured. Pass the publishable key here or make the RP-domain variable required.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-24T09:17:00Z

+    return Promise.resolve(null);
+  }
+
+  desktopBearerTokenPromise ??= bridge.getLocalEnvironmentBearerToken().catch((error) => {


Refresh cached desktop bearer tokens

This promise is cached forever after the first successful exchange, and the main-process cache stores only access_token while discarding the response expires_in. Desktop bearer sessions are expiring auth sessions, so a long-lived desktop app will keep attaching the expired token to primary-environment HTTP and WebSocket authorization until a full app restart. Cache the expiry and re-exchange or otherwise renew before expiry.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-24T09:17:00Z

-    const applicationUrl = environment.isDevelopment
-      ? yield* resolveDesktopDevServerUrl(environment)
-      : backendHttpUrl.href;
+    const applicationUrl = getDesktopUrl(environment.isDevelopment);


Reject opaque-origin renderer navigations

With the main window now loaded from t3code://app/, the existing isSameOriginRendererNavigation check compares URL.origin, which is "null" for this custom scheme in the Electron main process and also for file:/data: URLs. A renderer-initiated navigation to one of those opaque-origin URLs will therefore pass the same-origin gate instead of being blocked, whereas the previous http://127.0.0.1 application URL did not. Compare the expected scheme/host explicitly or reject opaque origins before allowing main-frame navigation.

Useful? React with 👍 / 👎.

mwolson and others added 19 commits June 18, 2026 20:20

fix(web): Remove saved environments atomically (pingdotgg#2917)

1fcc57a

Add archived threads and mobile file viewer (pingdotgg#3155)

30034ec

Co-authored-by: Julius Marminge <julius@mac.lan> Co-authored-by: codex <codex@users.noreply.github.com>

Add origin-based worktree bootstrap option (pingdotgg#3157)

52a24c8

fix(server): use bound host for MCP endpoint (pingdotgg#3114)

0651af9

fix(ssh): fix support for remotes that use fnm (pingdotgg#2641)

804d44c

Co-authored-by: Cursor <cursoragent@cursor.com>

Avoid repeated theme DOM sync during startup (pingdotgg#2779)

20f37f3

Co-authored-by: Julius Marminge <jmarminge@gmail.com>

Migrate desktop auth to Clerk bridge (pingdotgg#3092)

3e01c4b

Co-authored-by: codex <codex@users.noreply.github.com>

feat: allow disabling provider update checks (pingdotgg#3130)

5d4e2fa

Co-authored-by: codex <codex@users.noreply.github.com>

[codex] fix: show nightly badge from primary web server version (ping…

7dc1823

…dotgg#3103) Co-authored-by: codex <codex@users.noreply.github.com>

feat(composer): clickable PR pill next to branch selector (pingdotgg#…

494350c

…3065) Co-authored-by: codex <codex@users.noreply.github.com>

Improve idiomatic Effect usage in config and Tailscale paths (pingdot…

a4446e2

…gg#3073) Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com> Co-authored-by: codex <codex@users.noreply.github.com>

feat(sidebar): worktree indicator on session rows (pingdotgg#3057)

d9f59be

Co-authored-by: codex <codex@users.noreply.github.com>

Only show enabled providers in picker sidebar (pingdotgg#3168)

fbf6263

Co-authored-by: Julius Marminge <julius@mac.lan>

Share thread state idle TTL across client atoms (pingdotgg#3163)

cdaba7f

Unify mobile typography tokens across the app (pingdotgg#3162)

e29ad76

Co-authored-by: codex <codex@users.noreply.github.com>

Harden preview ownership and option-based secret handling (pingdotgg#…

753bc46

…3172)

sync: merge upstream post-connection runtime fixes

7ea1394

This was referenced Jun 24, 2026

Improve inline panel, file preview, and MCP session handling (#3121) #115

Merged

[codex] Inline contracts request-context service shapes (#3204) #118

Merged

github-actions Bot added size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 24, 2026

aaditagrawal added 11 commits June 24, 2026 12:21

Fix preview CI checks

e283736

Fix provider diagnostics checks

e1a2ff7

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

7271996

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

cc76a0a

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

0659718

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

a3146c5

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

308d76f

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

f9c3c5f

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

a865f9e

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

9fd2b1e

…nc/upstream-20260619-post-connection-runtime

Merge branch 'sync/upstream-20260618-connection-architecture' into sy…

55f8bd3

…nc/upstream-20260619-post-connection-runtime

aaditagrawal marked this pull request as ready for review June 24, 2026 08:45

aaditagrawal changed the base branch from sync/upstream-20260618-connection-architecture to main June 24, 2026 08:53

aaditagrawal merged commit 179dd20 into main Jun 24, 2026
26 of 28 checks passed

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): Remove saved environments atomically (#2917)#117

fix(web): Remove saved environments atomically (#2917)#117
aaditagrawal merged 30 commits into
mainfrom
sync/upstream-20260619-post-connection-runtime

aaditagrawal commented Jun 24, 2026

Uh oh!

aaditagrawal commented Jun 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

		Electron.protocol.handle(input.scheme, (request) =>
		proxyRequest(request, input.targetOrigin, contentSecurityPolicy),

Conversation

aaditagrawal commented Jun 24, 2026

What Changed

Why

UI Changes

Checklist

Uh oh!

aaditagrawal commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

aaditagrawal commented Jun 24, 2026 •

edited

Loading

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading