Skip to content

Release v0.31.0#3568

Merged
ebuchman merged 104 commits intomasterfrom
release/v0.31.0
Feb 9, 2019
Merged

Release v0.31.0#3568
ebuchman merged 104 commits intomasterfrom
release/v0.31.0

Conversation

@alessio
Copy link
Copy Markdown
Contributor

@alessio alessio commented Feb 9, 2019

Release branch for v0.31.0

Corresponding PR back to develop: #3569


  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

jaekwon and others added 30 commits January 24, 2019 13:49
Release v0.30.0 back to develop
* Check non-nil values on IAVL store
* Reuse assertValidValue
* Upgrading to ledger-cosmos-go
* Add cli test and update PENDING.md
…eviously broke ABI

* version prints out short info by default

Handle -o json, add --long flag to print full version info.

* Add distclean target to Makefile

* Update PENDING.md

* Add missing targets in .PHONY
- Remove --long from git describe. Appending commit info on tagged
  revisions is redundant.
- $(subst v,,$(shell git describe --tags --long)) was removing any
  occurrence of 'v'. Rather we want to remove only the 'v' prefix
  from tags.
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2019

Codecov Report

Merging #3568 into master will increase coverage by 2.62%.
The diff coverage is 54%.

@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
+ Coverage   58.86%   61.48%   +2.62%     
==========================================
  Files         131      186      +55     
  Lines        9836    13978    +4142     
==========================================
+ Hits         5790     8595    +2805     
- Misses       3671     4836    +1165     
- Partials      375      547     +172

Copy link
Copy Markdown
Contributor

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: SHIP IT!

Copy link
Copy Markdown
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending multi-sim by @zmanian

@zmanian
Copy link
Copy Markdown
Contributor

zmanian commented Feb 9, 2019

Multi-sim completed and passed.

Copy link
Copy Markdown
Contributor

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go team!

@ebuchman ebuchman merged commit 09688d0 into master Feb 9, 2019
@ebuchman ebuchman deleted the release/v0.31.0 branch February 9, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.