Skip to content

[None][fix] Revert "Merge Eagle3 and MTP-eagle one-model workers (#12353)" - #15217

Closed
tensorrt-cicd wants to merge 119 commits into
NVIDIA:chenfeiz/bisect-6280721-2762-basefrom
chenfeiz0326:revert-mtp-eagle-12353
Closed

[None][fix] Revert "Merge Eagle3 and MTP-eagle one-model workers (#12353)"#15217
tensorrt-cicd wants to merge 119 commits into
NVIDIA:chenfeiz/bisect-6280721-2762-basefrom
chenfeiz0326:revert-mtp-eagle-12353

Conversation

@tensorrt-cicd

@tensorrt-cicd tensorrt-cicd commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit 8e5d9e2 (#12353).

Summary

The MTP-eagle / Eagle3 one-model worker merge (#12353) regresses the GB200 2-node disagg perf-sanity gen-only test:

test_perf_sanity.py::test_e2e[disagg_upload-gen_only-gb200_deepseek-v32-fp4_1k1k_con2048_ctx1_dep4_gen1_dep4_eplb0_mtp1_ccb-NIXL]

Failure signature

The GEN server (MTP speculative decoding, num_nextn_predict_layers=1) crashes during executor init while capturing the generation-phase CUDA graphs. All 4 gen ranks abort with exit code 134, so the benchmark never runs:

File "model_engine.py", line 1169, in _run_cuda_graph_warmup
    self._capture_generation_cuda_graphs(resource_manager)
File "model_engine.py", line 1240, in _capture_generation_cuda_graphs
    torch.cuda.synchronize()
torch.AcceleratorError: CUDA error: unspecified launch failure

Bisect

Comparing the last passing post-merge commit 33b0a32 with the first failing one 316430f (12 commits): #12353 is the only change touching the spec-decode / model_engine CUDA-graph capture path. The remaining commits in the range are AutoDeploy, test, and infra changes (none touch deepseek-v32 / MoE / attention / CUDA-graph / spec-decode kernels). The cutlass-dsl version is unchanged across the range.

Reverting restores gen-server startup and unblocks the perf-sanity test.

Summary by CodeRabbit

  • Refactor

    • Refactored EAGLE3 one-model speculative decoding to streamline linear-tree processing and remove legacy code paths.
    • Simplified speculative decoding worker constructors and method signatures for improved maintainability.
    • Consolidated speculative metadata handling and removed redundant parameters.
  • Chores

    • Cleaned up license header comments and reorganized import statements across speculative decoding modules.
    • Updated configuration field types in MTPDecodingConfig from constrained to standard numeric types.

kaiyux and others added 30 commits June 5, 2026 14:58
…VIDIA#14997)

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Signed-off-by: Xiwen Yu <13230610+VALLIS-NERIA@users.noreply.github.com>
Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
NVIDIA#14995)

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
… GLM4.7 Flash test (NVIDIA#14999)

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
…erage, and AI Failure Analysis (NVIDIA#14528)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…IA#15003)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Emma Qiao <qqiao@nvidia.com>
…ey can run f… (NVIDIA#15001)

Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
…LLM(...)` constructor and removed the… (NVIDIA#14892)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
… standalone tests (NVIDIA#14954)

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
… (single GPU, aggregated for now) (NVIDIA#14578)

Signed-off-by: Thor Johnsen <41591019+thorjohnsen@users.noreply.github.com>
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
…ading and pre-fetch checking (NVIDIA#14021)

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
…s shapes (NVIDIA#14977)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
…A#15010)

Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
Signed-off-by: Alyosha-Swamy <raghav@arcee.ai>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
…VIDIA#14684)

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Co-authored-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
…okens (NVIDIA#13723)

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
…onfig / --extra_llm_api_options YAML (NVIDIA#14812)

Signed-off-by: marinayanov <256585945+marinayanov@users.noreply.github.com>
Signed-off-by: Bo Deng <deemod@nvidia.com>
Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
…DIA#15015)

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
…h Cutlass backend - Part 1 (NVIDIA#14923)

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@tensorrt-cicd
tensorrt-cicd requested review from a team as code owners June 15, 2026 07:06
@tensorrt-cicd
tensorrt-cicd requested review from a team June 15, 2026 07:06
@tensorrt-cicd
tensorrt-cicd requested review from a team as code owners June 15, 2026 07:06
@tensorrt-cicd
tensorrt-cicd requested review from 2ez4bz, mzweilz, qiaoxj07, yechank-nvidia and yiqingy0 and removed request for a team June 15, 2026 07:06
@chzblych
chzblych deleted the branch NVIDIA:chenfeiz/bisect-6280721-2762-base June 16, 2026 06:24
@chzblych chzblych closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.