release/v0.1.10: Phase 10 — Real Image Conversion Drivers#141
Merged
menvil merged 37 commits intoJun 1, 2026
Conversation
Phase 9: Conversion Job Core (CONV-112–CONV-129)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ocessing-packages CONV-130: Install image processing packages
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-test-fixtures CONV-131: Add image driver test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…driver CONV-132: Test PNG to JPG driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-jpg-driver CONV-133: Implement PNG to JPG driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…driver CONV-134: Test JPG to PNG driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-png-driver CONV-135: Implement JPG to PNG driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-driver CONV-136: Test PNG to WEBP driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-webp-driver CONV-137: Implement PNG to WEBP driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-driver CONV-138: Test JPG to WEBP driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-webp-driver CONV-139: Implement JPG to WEBP driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ration-package CONV-140: Install PDF generation package
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…driver CONV-141: Test PNG to PDF driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-pdf-driver CONV-142: Implement PNG to PDF driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…driver CONV-143: Test JPG to PDF driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-pdf-driver CONV-144: Implement JPG to PDF driver
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…age-drivers CONV-145: Register real image drivers
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…integration-smoke-tests CONV-146: Add real driver integration smoke tests
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (7)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds six image conversion drivers (JPG↔PNG, JPG/PNG↔WebP, JPG/PNG→PDF) with a shared trait for single-image PDF rendering, test fixtures and factories, and service provider registration to integrate drivers into the converter registry. ChangesImage Conversion Drivers & PDF Rendering Pipeline
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly Related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
tests/Support/ConversionContextFactory.php (1)
17-33: 💤 Low value
$outputExtensionis never used.The parameter is accepted but not referenced;
ConversionContexthas no output-extension field and drivers hardcode their own output filename/extension. It reads as if it influences the output, which it doesn't. Consider either documenting why it's retained for call-site readability or dropping it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/Support/ConversionContextFactory.php` around lines 17 - 33, The forSourcePath factory currently accepts an unused parameter $outputExtension; remove this dead parameter from the method signature in ConversionContextFactory::forSourcePath and from all places that call it, and update any tests or call-sites to stop passing an output extension; leave the function body as-is (it already constructs FileRecord, ConversionJob and returns ConversionContext) and ensure ConversionContext::class or driver code is not expecting an output extension field (no changes needed there).app/Conversion/Drivers/Image/JpgToWebpDriver.php (1)
25-26: ⚡ Quick winConsider adding error handling for image decoding.
If the source file is corrupted or not a valid JPEG,
decodePath()may throw an exception. While Laravel's exception handler will catch it, adding explicit error handling would provide better context for debugging conversion failures.🛡️ Suggested error handling
$sourcePath = Storage::disk('local')->path($context->sourceFile->stored_path); -$image = $manager->decodePath($sourcePath); +try { + $image = $manager->decodePath($sourcePath); +} catch (\Exception $e) { + throw new \RuntimeException("Failed to decode JPG image: {$e->getMessage()}", 0, $e); +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/Conversion/Drivers/Image/JpgToWebpDriver.php` around lines 25 - 26, Wrap the call to $manager->decodePath($sourcePath) in a try/catch inside JpgToWebpDriver (around where $sourcePath is built from Storage::disk('local')->path($context->sourceFile->stored_path)) to catch decoding exceptions, log or attach contextual details (e.g., $context->sourceFile->stored_path and any file id) and either rethrow a more descriptive ConversionException or return a clear failure result so callers see why decode failed; ensure the catch only handles decodePath errors and preserves the original exception message for debugging.app/Conversion/Drivers/Image/Concerns/RendersSingleImagePdf.php (1)
40-56: ⚡ Quick winConsider using Intervention Image instead of procedural GD functions.
The
resolveOrientationmethod uses procedural GD functions (imagecreatefromstring,imagesx,imagesy,imagedestroy), while the rest of the codebase uses Intervention Image (as seen inJpgToWebpDriver). This creates an inconsistency in image handling approach. Additionally, the silent fallback to'portrait'on line 48 whenimagecreatefromstringfails could mask legitimate errors during development.Using Intervention Image would provide better consistency, error reporting, and maintainability.
♻️ Proposed refactor using Intervention Image
+use Intervention\Image\Drivers\Gd\Driver; +use Intervention\Image\ImageManager; + private function resolveOrientation(string $orientation, string $imageContent): string { if ($orientation !== 'auto') { return $orientation; } - $image = imagecreatefromstring($imageContent); - if ($image === false) { - return 'portrait'; - } - - $width = imagesx($image); - $height = imagesy($image); - imagedestroy($image); + try { + $manager = new ImageManager(new Driver); + $image = $manager->read($imageContent); + $width = $image->width(); + $height = $image->height(); + } catch (\Exception $e) { + return 'portrait'; + } return $width > $height ? 'landscape' : 'portrait'; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/Conversion/Drivers/Image/Concerns/RendersSingleImagePdf.php` around lines 40 - 56, The resolveOrientation method currently uses procedural GD functions; replace that logic with Intervention Image (use ImageManager or the app's Image facade as used in JpgToWebpDriver) to open the image buffer, get width/height via ->width() and ->height(), and determine 'landscape' vs 'portrait'; also remove the silent fallback—catch any Exception from Intervention Image::make(...) and either rethrow or return a clearly logged error (do not silently return 'portrait') so failures are surfaced during development.app/Conversion/Drivers/Image/PngToJpgDriver.php (1)
47-56: ⚡ Quick winExtract the duplicated quality mapping into a shared concern.
resolveQuality()is byte-for-byte identical here, inPngToWebpDriver(andJpgToWebpDriverper the stack). Keeping three copies risks the mapping drifting between formats. Since aConcerns/directory already exists, move this into a shared trait (e.g.ResolvesImageQuality) anduseit in each driver.♻️ Suggested extraction
// app/Conversion/Drivers/Image/Concerns/ResolvesImageQuality.php <?php declare(strict_types=1); namespace App\Conversion\Drivers\Image\Concerns; trait ResolvesImageQuality { private function resolveQuality(mixed $quality): int { return match ($quality) { 'low' => 60, 'medium' => 75, 'high' => 90, 'max' => 100, default => 85, }; } }Then drop the local
resolveQuality()from each driver and adduse ResolvesImageQuality;to the class.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/Conversion/Drivers/Image/PngToJpgDriver.php` around lines 47 - 56, Extract the duplicate resolveQuality implementation into a shared trait named ResolvesImageQuality inside the existing Concerns namespace and have each driver (PngToJpgDriver, PngToWebpDriver, JpgToWebpDriver) use that trait; specifically, create the trait with the existing resolveQuality(mixed $quality): int mapping, remove the local resolveQuality methods from the three driver classes, and add use ResolvesImageQuality; in each class so they share a single authoritative implementation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/Conversion/Drivers/Image/Concerns/RendersSingleImagePdf.php`:
- Line 16: The fetch of the source file using
Storage::disk('local')->get($context->sourceFile->stored_path) in
RendersSingleImagePdf lacks error handling; update the code to first validate
the file exists and is readable (e.g., Storage::disk('local')->exists(...) or
isReadable) and/or wrap the get() call in a try-catch, and when missing or
unreadable throw or return a clear, contextual error that includes
$context->sourceFile->stored_path (and class/method context) so callers can
understand which source file failed (reference the RendersSingleImagePdf concern
and the $sourceContent retrieval).
---
Nitpick comments:
In `@app/Conversion/Drivers/Image/Concerns/RendersSingleImagePdf.php`:
- Around line 40-56: The resolveOrientation method currently uses procedural GD
functions; replace that logic with Intervention Image (use ImageManager or the
app's Image facade as used in JpgToWebpDriver) to open the image buffer, get
width/height via ->width() and ->height(), and determine 'landscape' vs
'portrait'; also remove the silent fallback—catch any Exception from
Intervention Image::make(...) and either rethrow or return a clearly logged
error (do not silently return 'portrait') so failures are surfaced during
development.
In `@app/Conversion/Drivers/Image/JpgToWebpDriver.php`:
- Around line 25-26: Wrap the call to $manager->decodePath($sourcePath) in a
try/catch inside JpgToWebpDriver (around where $sourcePath is built from
Storage::disk('local')->path($context->sourceFile->stored_path)) to catch
decoding exceptions, log or attach contextual details (e.g.,
$context->sourceFile->stored_path and any file id) and either rethrow a more
descriptive ConversionException or return a clear failure result so callers see
why decode failed; ensure the catch only handles decodePath errors and preserves
the original exception message for debugging.
In `@app/Conversion/Drivers/Image/PngToJpgDriver.php`:
- Around line 47-56: Extract the duplicate resolveQuality implementation into a
shared trait named ResolvesImageQuality inside the existing Concerns namespace
and have each driver (PngToJpgDriver, PngToWebpDriver, JpgToWebpDriver) use that
trait; specifically, create the trait with the existing resolveQuality(mixed
$quality): int mapping, remove the local resolveQuality methods from the three
driver classes, and add use ResolvesImageQuality; in each class so they share a
single authoritative implementation.
In `@tests/Support/ConversionContextFactory.php`:
- Around line 17-33: The forSourcePath factory currently accepts an unused
parameter $outputExtension; remove this dead parameter from the method signature
in ConversionContextFactory::forSourcePath and from all places that call it, and
update any tests or call-sites to stop passing an output extension; leave the
function body as-is (it already constructs FileRecord, ConversionJob and returns
ConversionContext) and ensure ConversionContext::class or driver code is not
expecting an output extension field (no changes needed there).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec155307-5f6a-454d-8c93-4b2bfe0718ac
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (21)
app/Conversion/Drivers/Image/Concerns/RendersSingleImagePdf.phpapp/Conversion/Drivers/Image/JpgToPdfDriver.phpapp/Conversion/Drivers/Image/JpgToPngDriver.phpapp/Conversion/Drivers/Image/JpgToWebpDriver.phpapp/Conversion/Drivers/Image/PngToJpgDriver.phpapp/Conversion/Drivers/Image/PngToPdfDriver.phpapp/Conversion/Drivers/Image/PngToWebpDriver.phpapp/Providers/ConverterServiceProvider.phpcomposer.jsonresources/views/pdf/single-image.blade.phptests/Feature/Conversion/ConverterDriverRegistryRealDriversTest.phptests/Feature/Conversion/Drivers/JpgToPdfDriverTest.phptests/Feature/Conversion/Drivers/JpgToPngDriverTest.phptests/Feature/Conversion/Drivers/JpgToWebpDriverTest.phptests/Feature/Conversion/Drivers/PngToJpgDriverTest.phptests/Feature/Conversion/Drivers/PngToPdfDriverTest.phptests/Feature/Conversion/Drivers/PngToWebpDriverTest.phptests/Feature/Conversion/ImageFixtureTest.phptests/Feature/Conversion/ProcessConversionJobRealDriverTest.phptests/Support/ConversionContextFactory.phptests/Support/ImageFixture.php
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 22 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…de corrections Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Phase 10 review fixes: source guards, shared quality trait, dompdf Blade corrections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 10 — Real Image Conversion Drivers
Задачи CONV-130–CONV-146.
What's included
Packages installed:
intervention/image ^4.1— PNG/JPG/WEBP image processing via GDbarryvdh/laravel-dompdf ^3.1— single-image PDF generationNew drivers (
app/Conversion/Drivers/Image/):PngToJpgDriverpng_to_jpgJpgToPngDriverjpg_to_pngPngToWebpDriverpng_to_webpJpgToWebpDriverjpg_to_webpPngToPdfDriverpng_to_pdfJpgToPdfDriverjpg_to_pdfRendersSingleImagePdftraitTest infrastructure:
Tests\Support\ImageFixture— programmatic PNG/JPG fixture generation (no committed binaries)Tests\Support\ConversionContextFactory— lightweightConversionContextbuilder for driver unit testsRegistry: All 6 drivers registered in
ConverterServiceProviderIntegration smoke tests:
ProcessConversionJobRealDriverTest— PNG→JPG, JPG→WEBP, PNG→PDF through the full queue pipelineTest plan
composer test)composer lintpassesnpm run buildpasses🤖 Generated with Claude Code
Summary by cubic
Adds six real image conversion drivers and registers them for end-to-end queue processing. Also adds source file guards, a shared quality resolver, and a refined PDF template. Covers CONV-130–CONV-146.
New Features
png_to_jpg,jpg_to_png,png_to_webp,jpg_to_webp,png_to_pdf,jpg_to_pdf(with source file existence guards).png_to_jpgfills transparency with a configurable background; shared quality resolver trait.resources/views/pdf/single-image.blade.php.Dependencies
intervention/image ^4.1for GD-based image processing.barryvdh/laravel-dompdf ^3.1for single-image PDF generation.Written for commit c217f16. Summary will update on new commits.
Summary by CodeRabbit
New Features
Tests
Chores