Sync feature branch resource identity

[BBBmau]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 718 files changed, 37912 insertions(+), 5593 deletions(-))
google-beta provider: Diff ( 750 files changed, 41296 insertions(+), 5762 deletions(-))
terraform-google-conversion: Diff ( 74 files changed, 8563 insertions(+), 360 deletions(-))
Open in Cloud Shell: Diff ( 67 files changed, 1752 insertions(+), 54 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field location changed from optional to required on google_compute_interconnect - reference
• Field settings.disk_type default value changed from PD_SSD to <nil> on google_sql_database_instance - reference
• Field tags within resource google_dataproc_metastore_service was either removed or renamed - reference
• Field tags within resource google_redis_instance was either removed or renamed - reference
• Field tags within resource google_secret_manager_secret was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_instance (117 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_instance" "primary" {
  cluster {
    node_scaling_factor = # value needed
  }
}

Resource: google_compute_future_reservation (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_future_reservation" "primary" {
  auto_created_reservations_delete_time = # value needed
  auto_created_reservations_duration {
    nanos   = # value needed
    seconds = # value needed
  }
  commitment_info {
    commitment_name           = # value needed
    commitment_plan           = # value needed
    previous_commitment_terms = # value needed
  }
  deployment_type  = # value needed
  reservation_mode = # value needed
  reservation_name = # value needed
  scheduling_type  = # value needed
  share_settings {
    projects = # value needed
  }
  specific_reservation_required = # value needed
  specific_sku_properties {
    instance_properties {
      guest_accelerators {
        accelerator_count = # value needed
        accelerator_type  = # value needed
      }
      local_ssds {
        disk_size_gb = # value needed
        interface    = # value needed
      }
      location_hint                     = # value needed
      maintenance_freeze_duration_hours = # value needed
      maintenance_interval              = # value needed
      min_cpu_platform                  = # value needed
    }
    source_instance_template = # value needed
  }
  status {
    amendment_status          = # value needed
    auto_created_reservations = # value needed
    fulfilled_count           = # value needed
    last_known_good_state {
      description = # value needed
      existing_matching_usage_info {
        count      = # value needed
        time_stamp = # value needed
      }
      future_reservation_specs {
        share_settings {
          project_map {
            project    = # value needed
            project_id = # value needed
          }
          projects   = # value needed
          share_type = # value needed
        }
        specific_sku_properties {
          instance_properties {
            guest_accelerators {
              accelerator_count = # value needed
              accelerator_type  = # value needed
            }
            local_ssds {
              disk_size_gb = # value needed
              interface    = # value needed
            }
            location_hint                     = # value needed
            machine_type                      = # value needed
            maintenance_freeze_duration_hours = # value needed
            maintenance_interval              = # value needed
            min_cpu_platform                  = # value needed
          }
          source_instance_template = # value needed
          total_count              = # value needed
        }
        time_window {
          duration {
            nanos   = # value needed
            seconds = # value needed
          }
          end_time   = # value needed
          start_time = # value needed
        }
      }
      lock_time          = # value needed
      name_prefix        = # value needed
      procurement_status = # value needed
    }
    lock_time          = # value needed
    procurement_status = # value needed
    specific_sku_properties {
      source_instance_template_id = # value needed
    }
  }
  time_window {
    duration {
      nanos   = # value needed
      seconds = # value needed
    }
  }
}

Resource: google_compute_instance_from_machine_image (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  attached_disk {
    force_attach = # value needed
  }
  boot_disk {
    force_attach = # value needed
  }
}

Resource: google_compute_instance_from_template (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  boot_disk {
    auto_delete                     = # value needed
    device_name                     = # value needed
    disk_encryption_key_raw         = # value needed
    disk_encryption_key_rsa         = # value needed
    disk_encryption_service_account = # value needed
    guest_os_features               = # value needed
    kms_key_self_link               = # value needed
    mode                            = # value needed
  }
}

Resource: google_container_cluster (459 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    flex_start = # value needed
    windows_node_config {
      osversion = # value needed
    }
  }
  node_pool {
    node_config {
      windows_node_config {
        osversion = # value needed
      }
    }
  }
}

Resource: google_dataplex_glossary_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_glossary_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dialogflow_cx_flow (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_flow" "primary" {
  knowledge_connector_settings {
    trigger_fulfillment {
      messages {
        mixed_audio {
          segments {
            audio = # value needed
            uri   = # value needed
          }
        }
      }
    }
  }
}

Resource: google_dialogflow_cx_page (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_page" "primary" {
  knowledge_connector_settings {
    target_flow = # value needed
    trigger_fulfillment {
      messages {
        mixed_audio {
          segments {
            audio = # value needed
            uri   = # value needed
          }
        }
      }
    }
  }
}

Resource: google_network_connectivity_spoke (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  reasons {
    code         = # value needed
    message      = # value needed
    user_details = # value needed
  }
}

Resource: google_storage_transfer_job (38 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_transfer_job" "primary" {
  transfer_spec {
    aws_s3_data_source {
      managed_private_network = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_cross_site_network
• google_compute_future_reservation

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_apigee_security_profile_v2, google_bigquery_row_access_policy, google_bigtable_logical_view, google_bigtable_materialized_view, google_compute_cross_site_network, google_compute_future_reservation, google_dataplex_glossary, google_dataplex_glossary_category, google_dataplex_glossary_iam_binding, google_dataplex_glossary_iam_member, google_dataplex_glossary_iam_policy, google_dataplex_glossary_term, google_firebase_app_hosting_default_domain, google_firebase_app_hosting_domain, google_firebase_app_hosting_traffic, google_iam_workload_identity_pool_iam_binding, google_iam_workload_identity_pool_iam_member, google_iam_workload_identity_pool_iam_policy, google_network_security_intercept_deployment, google_network_security_intercept_deployment_group, google_network_security_intercept_endpoint_group, google_network_security_intercept_endpoint_group_association, google_resource_manager_capability. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance
  • Expected Document Path: /website/docs/r/compute_instance.html.markdown
  • Fields: [attached_disk.force_attach]
• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [attached_disk.force_attach boot_disk.force_attach]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [attached_disk.force_attach boot_disk.force_attach]
• google_compute_instance_template
  • Expected Document Path: /website/docs/r/compute_instance_template.html.markdown
  • Fields: [disk.disk_encryption_key.kms_key_service_account]
• google_compute_region_instance_template
  • Expected Document Path: /website/docs/r/compute_region_instance_template.html.markdown
  • Fields: [disk.disk_encryption_key.kms_key_service_account]
• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_config.flex_start]
• google_container_node_pool
  • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
  • Fields: [node_config.flex_start]
• google_memorystore_instance
  • Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
  • Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]
• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [settings.connection_pool_config settings.connection_pool_config.connection_pooling_enabled settings.connection_pool_config.flags settings.connection_pool_config.flags.name settings.connection_pool_config.flags.value]

[modular-magician]

Tests analytics

Total tests: 4962
Passed tests: 4494
Skipped tests: 460
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeSecurityProfileV2_apigeeSecurityProfileV2BasicTestExample
• TestAccBigtableInstance_createWithNodeScalingFactorDefault
• TestAccBigtableInstance_createWithNodeScalingFactorThenUpdateViaForceNew
• TestAccBigtableLogicalView_bigtableLogicalViewExample
• TestAccBigtableLogicalView_update
• TestAccBigtableMaterializedView_bigtableMaterializedViewExample
• TestAccBigtableMaterializedView_deletionProtection
• TestAccBigtableTable_automated_backups_explicitly_disabled_on_create
• TestAccCloudRunService_cloudRunServiceWithManualScaling
• TestAccCloudRunService_cloudRunServiceWithMinInstance
• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withAndWithoutCondition
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withAndWithoutCondition

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComposerEnvironment_UpdateComposerV2ImageVersion
• TestAccComposerEnvironment_UpdateComposerV2ResilienceMode
• TestAccComposerEnvironment_UpdateComposerV2WithTriggerer
• TestAccContainerNodePool_withMultiNicNetworkConfig
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccLoggingFolderSettings_update
• TestAccMemorystoreInstanceDatasourceConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComposerEnvironment_UpdateComposerV2ImageVersion [Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode [Debug log]
TestAccComposerEnvironment_UpdateComposerV2WithTriggerer [Debug log]
TestAccContainerNodePool_withMultiNicNetworkConfig [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccMemorystoreInstanceDatasourceConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test