Sync feature branch 7.0.0#14353
Sync feature branch 7.0.0#14353c2thorn merged 402 commits intoGoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0from
Conversation
…on a `FREE_INSTANCE` via terraform (GoogleCloudPlatform#13851) Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Shrishty Chandra <shrishty@google.com>
Signed-off-by: James Alseth <jalseth@google.com> Co-authored-by: Riley Karson <rileykarson@google.com>
…m#14000) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
…ogleCloudPlatform#13878) Co-authored-by: Nick Elliot <nickelliot@google.com>
…tform#14328) Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_apihub_plugin_instance" "primary" {
actions {
action_id = # value needed
curation_config {
curation_type = # value needed
custom_curation {
curation = # value needed
}
}
schedule_cron_expression = # value needed
schedule_time_zone = # value needed
}
auth_config {
api_key_config {
api_key {
secret_version = # value needed
}
http_element_location = # value needed
name = # value needed
}
auth_type = # value needed
google_service_account_config {
service_account = # value needed
}
oauth2_client_credentials_config {
client_id = # value needed
client_secret {
secret_version = # value needed
}
}
user_password_config {
password {
secret_version = # value needed
}
username = # value needed
}
}
disable = # value needed
display_name = # value needed
location = # value needed
plugin = # value needed
plugin_instance_id = # value needed
}
Resource: resource "google_bigtable_instance" "primary" {
cluster {
node_scaling_factor = # value needed
}
}
Resource: resource "google_cloud_identity_group_membership" "primary" {
create_ignore_already_exists = # value needed
}
Resource: resource "google_cloud_run_v2_worker_pool" "primary" {
scaling {
max_instance_count = # value needed
min_instance_count = # value needed
}
template {
containers {
depends_on = # value needed
}
encryption_key = # value needed
encryption_key_revocation_action = # value needed
encryption_key_shutdown_duration = # value needed
gpu_zonal_redundancy_disabled = # value needed
}
}
Resource: resource "google_cloud_run_v2_worker_pool_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_cloud_run_v2_worker_pool_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_compute_future_reservation" "primary" {
auto_created_reservations_delete_time = # value needed
auto_created_reservations_duration {
nanos = # value needed
seconds = # value needed
}
commitment_info {
commitment_name = # value needed
commitment_plan = # value needed
previous_commitment_terms = # value needed
}
deployment_type = # value needed
reservation_mode = # value needed
reservation_name = # value needed
scheduling_type = # value needed
share_settings {
projects = # value needed
}
specific_reservation_required = # value needed
specific_sku_properties {
instance_properties {
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
local_ssds {
disk_size_gb = # value needed
interface = # value needed
}
location_hint = # value needed
maintenance_freeze_duration_hours = # value needed
maintenance_interval = # value needed
min_cpu_platform = # value needed
}
source_instance_template = # value needed
}
status {
amendment_status = # value needed
auto_created_reservations = # value needed
fulfilled_count = # value needed
last_known_good_state {
description = # value needed
existing_matching_usage_info {
count = # value needed
time_stamp = # value needed
}
future_reservation_specs {
share_settings {
project_map {
project = # value needed
project_id = # value needed
}
projects = # value needed
share_type = # value needed
}
specific_sku_properties {
instance_properties {
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
local_ssds {
disk_size_gb = # value needed
interface = # value needed
}
location_hint = # value needed
machine_type = # value needed
maintenance_freeze_duration_hours = # value needed
maintenance_interval = # value needed
min_cpu_platform = # value needed
}
source_instance_template = # value needed
total_count = # value needed
}
time_window {
duration {
nanos = # value needed
seconds = # value needed
}
end_time = # value needed
start_time = # value needed
}
}
lock_time = # value needed
name_prefix = # value needed
procurement_status = # value needed
}
lock_time = # value needed
procurement_status = # value needed
specific_sku_properties {
source_instance_template_id = # value needed
}
}
time_window {
duration {
nanos = # value needed
seconds = # value needed
}
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
attached_disk {
force_attach = # value needed
}
boot_disk {
force_attach = # value needed
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
boot_disk {
auto_delete = # value needed
device_name = # value needed
disk_encryption_key_raw = # value needed
disk_encryption_key_rsa = # value needed
disk_encryption_service_account = # value needed
guest_os_features = # value needed
kms_key_self_link = # value needed
mode = # value needed
}
}
Resource: resource "google_compute_interconnect_attachment_group" "primary" {
attachments {
attachment = # value needed
name = # value needed
}
interconnect_group = # value needed
}
Resource: resource "google_compute_interconnect_group" "primary" {
interconnects {
interconnect = # value needed
name = # value needed
}
}
Resource: resource "google_compute_network_firewall_policy" "primary" {
policy_type = # value needed
}
Resource: resource "google_compute_network_firewall_policy_with_rules" "primary" {
policy_type = # value needed
}
Resource: resource "google_compute_region_url_map" "primary" {
path_matcher {
default_route_action {
cors_policy {
allow_origin_regexes = # value needed
}
max_stream_duration {
nanos = # value needed
seconds = # value needed
}
url_rewrite {
path_template_rewrite = # value needed
}
}
}
}
Resource: resource "google_compute_service_attachment" "primary" {
send_propagated_connection_limit_if_zero = # value needed
}
Resource: resource "google_compute_url_map" "primary" {
path_matcher {
route_rules {
route_action {
request_mirror_policy {
mirror_percent = # value needed
}
}
}
}
}
Resource: resource "google_container_cluster" "primary" {
node_config {
windows_node_config {
osversion = # value needed
}
}
node_pool {
network_config {
network_performance_config {
total_egress_bandwidth_tier = # value needed
}
pod_ipv4_cidr_block = # value needed
}
node_config {
advanced_machine_features {
performance_monitoring_unit = # value needed
}
windows_node_config {
osversion = # value needed
}
}
placement_policy {
tpu_topology = # value needed
}
}
}
Resource: resource "google_dataplex_glossary_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_glossary_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dialogflow_cx_flow" "primary" {
knowledge_connector_settings {
trigger_fulfillment {
messages {
mixed_audio {
segments {
audio = # value needed
uri = # value needed
}
}
}
}
}
}
Resource: resource "google_dialogflow_cx_page" "primary" {
knowledge_connector_settings {
target_flow = # value needed
trigger_fulfillment {
messages {
mixed_audio {
segments {
audio = # value needed
uri = # value needed
}
}
}
}
}
}
Resource: resource "google_netapp_volume" "primary" {
hybrid_replication_parameters {
cluster_location = # value needed
description = # value needed
labels = # value needed
peer_cluster_name = # value needed
peer_ip_addresses = # value needed
peer_svm_name = # value needed
peer_volume_name = # value needed
replication = # value needed
}
}
Resource: resource "google_network_connectivity_spoke" "primary" {
reasons {
code = # value needed
message = # value needed
user_details = # value needed
}
}
Resource: resource "google_pubsub_topic" "primary" {
message_transforms {
disabled = # value needed
}
}
Resource: resource "google_storage_bucket_object" "primary" {
detect_md5hash = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
The following data sources are missing documents:
Errors
|
NickElliot
left a comment
There was a problem hiding this comment.
no changes made to feature branch yet, despite errors it will just mirror main
0afb840
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 5315 Click here to see the affected service packages
Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
This reverts commit 0afb840.
This reverts commit 0afb840.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.